{{ message }}
Avoid copies in sorting#1967
Merged
Merged
Conversation
Also remove explicit specialization in std::min, quotient_ceil calls where both arguments have the same type so that type deduction works.
The map_back operation is a no-op then.
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_442 ran successfully. |
Collaborator
ndgrigorian
reviewed
Jan 15, 2025
ndgrigorian
previously approved these changes
Jan 15, 2025
ndgrigorian
left a comment
ndgrigorian
left a comment
Collaborator
There was a problem hiding this comment.
Aside from that small nit LGTM!
ndgrigorian
previously approved these changes
Jan 15, 2025
Collaborator
|
@oleksandr-pavlyk |
Use bracketed if statement Co-authored-by: ndgrigorian <46709016+ndgrigorian@users.noreply.github.com>
oleksandr-pavlyk
force-pushed
the
avoid-copies-in-sorting
branch
from
1d6f4f7 to
4847101
Compare
ndgrigorian
approved these changes
Jan 15, 2025
ndgrigorian
left a comment
ndgrigorian
left a comment
Collaborator
There was a problem hiding this comment.
Pre-commit fixed again, so I will approve, and hopefully it won't be too hasty this time :)
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_450 ran successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use forwarding references to avoid copies of comparator cpp-function, and of iterator.
Also avoid invoking
map_backkernel inargsortwhen arg-sorting 1d array, i.e. wheniter_nelems == 1.