{{ message }}
Conversation
dzenanz
approved these changes
Nov 15, 2022
Collaborator
Author
Member
|
I have not seen this issue before. By a quick search, it does not seem to be common. |
Collaborator
Author
|
Perhaps some mismatch between MSVC versions? Or old ITK build artifacts were somehow swept up in the build? @thewtex Would you please provide specs on the Windows machine used to build Windows v5.3rc04.post4 release artifacts? |
Member
|
@tbirdso yes, it is likely compiler versions -- I created the v5.3rc04.post4 on a system with VS 2022 -- the previous were created on VS 2019 (this is not the same as the MSVC toolchain version, but likely an earlier version). @tbirdso could you please try |
Resolves compiler mismatch issue where ITK v5.3rc04.post4 build archives were built with VS22 compiler
tbirdso
force-pushed
the
bump-itk
branch
2 times, most recently
from
7a7cf71 to
6a26dd5
Compare
Addresses Windows cxx build warnings due to MSVC discovery issues that were fixed in CMake v3.21.3. The closest available tag for the `lukka/get-cmake` action is v3.22.2, which also updates `ninja` to 1.10.2. https://gitlab.kitware.com/cmake/cmake/-/merge_requests/6497 https://github.com/lukka/get-cmake/releases/tag/v3.22.2
Collaborator
Author
tbirdso
added a commit
to InsightSoftwareConsortium/ITKModuleTemplate
that referenced
this pull request
Nov 18, 2022
Updates cookiecutter CI workflow to rely on ITKRemoteModuleBuildTestPackageAction reusable workflows for easier maintenance. Updates ITK reference to v5.3rc04.post4 and applies version updates from reusable workflow. See InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#9
jhlegarreta
pushed a commit
to jhlegarreta/ITKModuleTemplate
that referenced
this pull request
Jul 2, 2024
Updates cookiecutter CI workflow to rely on ITKRemoteModuleBuildTestPackageAction reusable workflows for easier maintenance. Updates ITK reference to v5.3rc04.post4 and applies version updates from reusable workflow. See InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pending successful ITKSplitComponents test workflow run
https://github.com/InsightSoftwareConsortium/ITKSplitComponents/actions/runs/3472832027