{{ message }}
Conversation
dzenanz
approved these changes
Nov 28, 2022
dzenanz
approved these changes
Nov 28, 2022
Collaborator
Author
tbirdso
force-pushed
the
bump-itk
branch
2 times, most recently
from
5ab9492 to
cfb9d2c
Compare
Collaborator
Author
|
Changes in this PR including ITKPythonPackage update step allow ITK modules to build against v5.3.0 successfully: https://github.com/InsightSoftwareConsortium/ITKSplitComponents/actions/runs/3569030832/jobs/5999692408 Also demonstrated that an older ITKPythonPackage tag can be used to revert to earlier build scripts, in this case recreating the now-fixed Windows failure: https://github.com/tbirdso/ITKSplitComponents/actions/runs/3569679773/jobs/5999869846 @dzenanz I have made several changes since your last review, I'll leave this up in case you'd like to re-review in the morning before merge. |
dzenanz
approved these changes
Nov 29, 2022
Collaborator
Author
SimonRit
pushed a commit
to SimonRit/RTK
that referenced
this pull request
Nov 29, 2022
SimonRit
pushed a commit
to SimonRit/ITKCudaCommon
that referenced
this pull request
Nov 29, 2022
SimonRit
pushed a commit
to SimonRit/RTK
that referenced
this pull request
Nov 29, 2022
SimonRit
pushed a commit
to SimonRit/RTK
that referenced
this pull request
Nov 29, 2022
SimonRit
pushed a commit
to SimonRit/RTK
that referenced
this pull request
Dec 14, 2022
hjmjohnson
pushed a commit
to hjmjohnson/RTK
that referenced
this pull request
Jan 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing in ITKSplitComponents draft PR: InsightSoftwareConsortium/ITKSplitComponents#65