Grammatical modifications added to the Galician translation in the texts of the corresponding .md files by raivenra · Pull Request #680 · InnerSourceCommons/InnerSourcePatterns · GitHub
Skip to content

Grammatical modifications added to the Galician translation in the texts of the corresponding .md files - #680

Merged
psanxiao merged 3 commits into
InnerSourceCommons:mainfrom
raivenra:modification-galician-texts
Apr 11, 2024
Merged

Grammatical modifications added to the Galician translation in the texts of the corresponding .md files#680
psanxiao merged 3 commits into
InnerSourceCommons:mainfrom
raivenra:modification-galician-texts

Conversation

@raivenra

Copy link
Copy Markdown
Contributor

Grammatical modifications added to the Galician translation in the texts of the corresponding .md files.

@welcome

welcome Bot commented Apr 10, 2024

Copy link
Copy Markdown

@raivenra
raivenra requested a review from psanxiao as a code owner April 10, 2024 08:29
Comment thread book/gl/toc.md Outdated
@spier spier added the Type - Translation Translating patterns into other languages label Apr 10, 2024
@psanxiao
psanxiao merged commit 8d3b020 into InnerSourceCommons:main Apr 11, 2024
@welcome

welcome Bot commented Apr 11, 2024

Copy link
Copy Markdown

Congratulations Banner
Congrats on merging your first pull request! 🎉 We here at The InnerSource Commons are proud of you! 💖 Thank you so much for your contribution 🎁

@spier

spier commented Apr 12, 2024

Copy link
Copy Markdown
Member

These changes are now live:
https://patterns.innersourcecommons.org/v/gl

Great job @raivenra and @psanxiao !

@spier

spier commented Apr 12, 2024

Copy link
Copy Markdown
Member

@psanxiao one question:
I noticed that the first letter in the Patlet of the translated patterns was changed to lowercase. I assume that was done to achieve the desired formatting in toc.md?

galego-toc

However this also means that when opening the pattern itself, it will look like this. Is this intended and correct in Galician to start a sentence with a lower case letter?

galego-patlet-modifications

@psanxiao

Copy link
Copy Markdown
Collaborator

Good point @spier . Changes are made because of TOC, correct. In the TOC, descriptions should be in lowercase in Galician, but as you pointed out, Patlets should start in uppercase since you're right, sentences in Galician start in uppercase.

I guess there is no a good solution for this with the current configuration of the repository. As lesser of two I think it would be better Patlets start in uppercase. Sorry about not realize of that. I have to make some other minor change nexts days so I could take advantage of it and make that change...

Or you think it would be better remove the commit of the PR from main branch and make another one taking this into account?

@spier

spier commented Apr 12, 2024

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type - Translation Translating patterns into other languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants