{{ message }}
feat(30-day-warranty): SAP known instance teaser - #679
Merged
Conversation
michael-basil
requested review from
NewMexicoKid,
cewilliams,
lenucksi,
robtuley,
spier and
yuhattor
as code owners
April 7, 2024 20:22
spier
added
2-structured
spier
reviewed
Apr 8, 2024
spier
left a comment
spier
left a comment
Member
There was a problem hiding this comment.
You are on a roll @michael-basil ! :)
I made some wording suggestions to make it more similar to the other Known Instance descriptions that we have. And sorry about the confusion that I created by using the term "teaser" before, as I think that sent you down on a wrong path.
If you have happy with my suggestion you can integrate it, and then I can merge this PR later today.
Co-authored-by: Sebastian Spier <github@spier.hu>
Contributor
Author
spier
approved these changes
Apr 8, 2024
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@spier @dellagustin - Teaser proposal as requested from #672