chore: change either to any - #668
Conversation
In its current context, there are 3 choices so `any` is more appropriate. `either` is for binary decisions (between 2 choices). Signed-off-by: jmeridth <jmeridth@gmail.com>
spier
left a comment
spier
left a comment
There was a problem hiding this comment.
Thank you for the fix. Hope you found it easy enough to figure out how to contribute?
Many of our patterns were written by contributors that speak English as a foreign language. So I am sure there are many more language/grammar improvements like this to be made 😃
Thanks again!
|
|
|
@spier Yes. Contribution process was very easy. Thank you. I'm re-reading the entire patterns book again and may have other PRs. This one was the gateway PR and felt very nitpicky but thank you for merging it. Cheers. |
|
That's great @jmeridth. Looking forward to any and all contributions that you want to make. And no worry about nitpicking, if we really don't want to make a change that you are suggesting, we can just talk about that in any future PRs. No harm done, quite the opposite actually, as it is always great to have somebody with fresh eyes read our patterns again! |
2 participants
In its current context, there are 3 choices so
anyis more appropriate.eitheris for binary decisions (between 2 choices).