Add new translation language: Galician by psanxiao · Pull Request #613 · InnerSourceCommons/InnerSourcePatterns · GitHub
Skip to content

Add new translation language: Galician - #613

Merged
spier merged 19 commits into
InnerSourceCommons:mainfrom
psanxiao:translation-gl
Nov 17, 2023
Merged

Add new translation language: Galician#613
spier merged 19 commits into
InnerSourceCommons:mainfrom
psanxiao:translation-gl

Conversation

@psanxiao

Copy link
Copy Markdown
Collaborator

This PR adds a new entirely translation to Galician language. Includes:

  • Translation of the structured patterns in translation/gl folder
  • Translation of the files within folder 'book' in book/gl folder
  • Translation of some of the graphics, that we created in a new gl folder into assets/img/gl

This translation was made possible thank you to Xunta de Galicia, local goverment of Galicia region, as part as project to foster InnerSource practiques among the Galician companies.

People who participate in the translation work were:

  • Leticia Gómez Cadahía
  • María Lucía González Castro

We hope you find interesting this contribution and we looking forward to your feedback. Let us know any change that we should made so that this PR could be integrated.

Thank you in advance for your time.

@welcome

welcome Bot commented Nov 15, 2023

Copy link
Copy Markdown

@psanxiao
psanxiao changed the base branch from translation-gl to main November 15, 2023 17:52
@spier

spier commented Nov 15, 2023

Copy link
Copy Markdown
Member

Awesomeness in the making @psanxiao! Will get back to this shortly.

@spier spier added the Type - Translation Translating patterns into other languages label Nov 15, 2023
@spier

spier commented Nov 15, 2023

Copy link
Copy Markdown
Member

@psanxiao thank you again for this contribution.

I made various tiny fixes to the markdown formatting. Those were just house-keeping items though, that make it simpler for us to maintain these patterns.

Further I found some broken links, which I fixed as well.

Just for two of these links I wasn't sure. I found these links to files that don't exist:

  • meta/gl/pattern-template.md
  • innersource-program-mind-map.png

I have fixed those links as well to point to the English version of those files instead. If you were still intending to translate those files to Galician too, you can certainly do that. However you don't have to as the translations to Japanese/Chinese etc have not done that either (i.e. they kept the English versions as well).

Also at least for the mind-map it will be a bit trickier to do the translation, as we have some automation there that generates the mindmap, which we would have to fix too.

@psanxiao

Copy link
Copy Markdown
Collaborator Author

Thank you very much @spier for reviewing and for all the fixes.

About those links that you mentioned, yeah, it was my fault. I did not upload those files in the previous commits. But, taking into account what you say, maybe it has no sense to upload the translation for those files.

@spier

spier commented Nov 16, 2023

Copy link
Copy Markdown
Member

Oh, well if you already have those fixes anyways, by all means, please add them to the PR @psanxiao !

@spier

spier commented Nov 16, 2023

Copy link
Copy Markdown
Member

Btw there is something that I need to clarify with the gitbook Support team before publishing the Galician version of the patterns. So it will likely take until early next week. Just to set expectations :)

@psanxiao

Copy link
Copy Markdown
Collaborator Author

Btw there is something that I need to clarify with the gitbook Support team before publishing the Galician version of the patterns. So it will likely take until early next week. Just to set expectations :)

No problem with that. Thank you very much for all your work done.

@spier

spier commented Nov 16, 2023

Copy link
Copy Markdown
Member

Btw there is something that I need to clarify with the gitbook Support team before publishing the Galician version of the patterns. So it will likely take until early next week. Just to set expectations :)

No problem with that. Thank you very much for all your work done.

You got it :)

Actually I think I was able to resolve the issue.
Should be able to release a bit sooner then :)

@spier

spier commented Nov 16, 2023

Copy link
Copy Markdown
Member

Note to self:
We will have to re-work the generate-mindmap.yml GitHub Action, to make sure that we re-generate the mindmap for Galician as well, if the input files change.

@spier

spier commented Nov 16, 2023

Copy link
Copy Markdown
Member

Also after this PR we get to do some continuity testing immediate, as in the meantime there is another pattern that needs translation :) (see Standard Release Process)

@spier

spier commented Nov 16, 2023

Copy link
Copy Markdown
Member

I think I checked this PR sufficiently now, and am happy to get this merged tomorrow, and published in our online book. This will be so cool 🥳

One more question for you though @psanxiao:
For each translation we have a translation lead. We have established that concept, as we don't speak these languages ourselves, so naturally we cannot review future contributions to these translations ourselves.

So, would you like to be the translation lead for Galician? :)

@spier spier changed the title Add new entirely translation to Galician Add new translation language: Galician Nov 17, 2023
@psanxiao

Copy link
Copy Markdown
Collaborator Author

So, would you like to be the translation lead for Galician? :)

Sure! :)

@spier
spier merged commit 591a213 into InnerSourceCommons:main Nov 17, 2023
@welcome

welcome Bot commented Nov 17, 2023

Copy link
Copy Markdown

Congratulations Banner
Congrats on merging your first pull request! 🎉 We here at The InnerSource Commons are proud of you! 💖 Thank you so much for your contribution 🎁

@spier

spier commented Nov 17, 2023

Copy link
Copy Markdown
Member

rmarting pushed a commit to rmarting/InnerSourcePatterns that referenced this pull request Feb 29, 2024
* Added Galician translation (incl. some translated images, mindmap, and pattern template)
* Added @psanxiao as translation lead for Galician

---------

Co-authored-by: Sebastian Spier <github@spier.hu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type - Translation Translating patterns into other languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants