Adding GovTech GPSL as a Known Instance to the InnerSource License pattern by spier · Pull Request #605 · InnerSourceCommons/InnerSourcePatterns · GitHub
Skip to content

Adding GovTech GPSL as a Known Instance to the InnerSource License pattern - #605

Merged
spier merged 6 commits into
mainfrom
ki-innersource-license-gpsl
Mar 5, 2024
Merged

Adding GovTech GPSL as a Known Instance to the InnerSource License pattern#605
spier merged 6 commits into
mainfrom
ki-innersource-license-gpsl

Conversation

@spier

@spier spier commented Oct 26, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #604.

Adding GovTech (Singapore Government) as a known instance to the InnerSource License pattern.
Description based on this ISC community call.

@spier spier changed the title Adding GovTech GPS as a Known Instance to the InnerSource License pattern Adding GovTech GPSL as a Known Instance to the InnerSource License pattern Oct 26, 2023
@spier
spier marked this pull request as ready for review October 26, 2023 13:42
@spier

spier commented Oct 26, 2023

Copy link
Copy Markdown
Member Author

@spier spier added 2-structured Patterns with existing instances (Please see our contribution handbook for details) 🐅 patterns-in-the-wild InnerSource patterns that were spotted in the wild. We can extract Known Instances and new patterns. labels Oct 26, 2023
@dellagustin-sap

dellagustin-sap commented Oct 26, 2023

Copy link
Copy Markdown
Contributor

Creating an issue as a note to yourself to work on it later and having someone else picking it up is one of the beauties of Open Source!
Thanks a lot @spier for the PR. I did a quick check my self and it is looking good.

@spier spier mentioned this pull request Nov 29, 2023
Closed
hunter
hunter approved these changes Mar 5, 2024
View reviewed changes

@hunter hunter left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spier
spier merged commit b27a5c7 into main Mar 5, 2024
@spier
spier deleted the ki-innersource-license-gpsl branch March 5, 2024 07:52
@spier

spier commented Mar 5, 2024

Copy link
Copy Markdown
Member Author

This is now live at https://patterns.innersourcecommons.org/p/innersource-license

Thanks @dellagustin-sap for the pointer and @hunter for description and confirmation!!!

@dellagustin-sap

dellagustin-sap commented Mar 5, 2024

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lenucksi lenucksi Awaiting requested review from lenucksi lenucksi is a code owner
@NewMexicoKid NewMexicoKid Awaiting requested review from NewMexicoKid NewMexicoKid is a code owner
@cewilliams cewilliams Awaiting requested review from cewilliams cewilliams is a code owner
@robtuley robtuley Awaiting requested review from robtuley robtuley is a code owner
@yuhattor yuhattor Awaiting requested review from yuhattor yuhattor is a code owner
1 more reviewer
@hunter hunter hunter approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2-structured Patterns with existing instances (Please see our contribution handbook for details) 🐅 patterns-in-the-wild InnerSource patterns that were spotted in the wild. We can extract Known Instances and new patterns.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Known Instance to InnerSource Licenses: Singapore Government

3 participants

@spier @dellagustin-sap @hunter