{{ message }}
Update changed link - #477
Merged
Merged
Conversation
robtuley
added
the
Type - Maintenance / Cleanup
robtuley
requested review from
NewMexicoKid,
cewilliams,
lenucksi,
spier and
yuhattor
as code owners
October 30, 2022 22:11
spier
reviewed
Oct 31, 2022
spier
left a comment
spier
left a comment
Member
There was a problem hiding this comment.
Thanks for the link fix @robtuley!
Also great that you found the bug in the GitHub Action. Great catch!
Looks like we need to look for better ways to test those :)
I left two comments inline where it looks like you changed some markdown formatting that isn't necessarily related to this PR. As part of that is related to the Japanese translation, and I don't speak that language, I am not sure if this will look correct to Japanese readers.
Collaborator
Author
spier
approved these changes
Nov 1, 2022
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simply updates a link that has changed. Apologies I should have left a redirect there.
EDIT: the PR link checker status check was failing, so this PR also adds a fix. This looks like it was introduced in #471 but looks like it has a bug in it when multiple *.md files are touched: the
findcommand returns a newline separated list of md files when what is required is a space spearated one so just added a quick fix for that.