Add README.md for translation process by yuhattor · Pull Request #429 · InnerSourceCommons/InnerSourcePatterns · GitHub
Skip to content

Add README.md for translation process - #429

Merged
yuhattor merged 4 commits into
InnerSourceCommons:book-jpfrom
yuhattor:book-jp
Jul 25, 2022
Merged

Add README.md for translation process#429
yuhattor merged 4 commits into
InnerSourceCommons:book-jpfrom
yuhattor:book-jp

Conversation

@yuhattor

@yuhattor yuhattor commented Jul 24, 2022

Copy link
Copy Markdown
Member

@spier
I have created a draft regarding the Translation Process. I may be missing some parts.

I'm a little confused, with the methodology you mentioned in #422, for example, when a Japanese community member sends a PR for a translation, should they send it to the book-jp branch? Or should they send PRs directly to main? From your description, it sounds like book-jp is just a place to put the artifacts.
It would be good to indicate here clearly which branch to send PRs to when others join the translation in the future.

When the process is somewhat finalized, I will create the Japanese version in translation/japanese/README.md as well.

Comment thread translation/README.md Outdated
Comment thread translation/README.md Outdated
Comment thread translation/README.md Outdated

@spier spier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together! Looks great already.

I left some inline comments for you to consider.

Please make your own judgement calls about my inline comments, and then just merge whatever version of this doc you are comfortable with.

That also allows us to confirm that you indeed have WRITE permissions on the repo now :)

One cosmetic suggestion:
If you don't mind, could you use the code syntax with a single backtick, rather than 3 backticks? That's how we have done it elsewhere in this repo so far, so it would make it more consistent. (I am adding one inline suggestion about this to the doc but the comment applies to all code blocks).

Update:
Don't worry about the failing checks.
I have taken care of them already.

Comment thread translation/README.md Outdated
@spier

spier commented Jul 24, 2022

Copy link
Copy Markdown
Member

@spier spier added the Type - Translation Translating patterns into other languages label Jul 25, 2022
Co-authored-by: Sebastian Spier <github@spier.hu>
Comment thread translation/README.md Outdated
@yuhattor

Copy link
Copy Markdown
Member Author

Comment thread translation/README.md Outdated
Comment thread translation/README.md Outdated
@yuhattor
yuhattor merged commit c0db317 into InnerSourceCommons:book-jp Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type - Translation Translating patterns into other languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants