Maturity model.md by AlexAndradeNet · Pull Request #315 · InnerSourceCommons/InnerSourcePatterns · GitHub
Skip to content

Maturity model.md - #315

Closed
AlexAndradeNet wants to merge 11 commits into
InnerSourceCommons:spell-check-actionfrom
AlexAndradeNet:maturity-model.md
Closed

Maturity model.md#315
AlexAndradeNet wants to merge 11 commits into
InnerSourceCommons:spell-check-actionfrom
AlexAndradeNet:maturity-model.md

Conversation

@AlexAndradeNet

Copy link
Copy Markdown
Contributor

No description provided.

@spier spier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see what feedback the author's provide about the changes to the Patlet.

I also reverted a couple of other changes that you made, in cases where I was reasonably sure that the original version was correct.

Comment thread patterns/2-structured/maturity-model.md
Comment thread patterns/2-structured/maturity-model.md Outdated
Comment thread patterns/2-structured/maturity-model.md Outdated
Comment thread patterns/2-structured/maturity-model.md Outdated
Comment thread patterns/2-structured/maturity-model.md Outdated
Comment thread patterns/2-structured/maturity-model.md Outdated
Comment thread patterns/2-structured/maturity-model.md Outdated
@spier

spier commented Mar 19, 2021

Copy link
Copy Markdown
Member

@spier spier self-assigned this Mar 19, 2021
@spier

spier commented Mar 24, 2021

Copy link
Copy Markdown
Member

hi @AlexAndradeSan. Just wanted to check in again to ask if you saw my last comment above? ⬆️

@spier

spier commented May 1, 2021

Copy link
Copy Markdown
Member

Hi @AlexAndradeSan, I am getting back to this PR now, to see if we can get these changes merged?
Note that in the meantime we have renamed our mainline branch to main, which is where we would like to merge these changes into.

@spier

spier commented May 15, 2021

Copy link
Copy Markdown
Member

Status update:
I have ported most of your other fixes in to main via PR #327.

Might later also revert those changes from the spell-check-action branch, as they don't really belong there.

Comment thread patterns/2-structured/maturity-model.md Outdated
Comment thread patterns/2-structured/maturity-model.md Outdated
@spier

spier commented Jul 4, 2021

Copy link
Copy Markdown
Member

Hi @AlexAndradeSan. Based on the feedback about the Patlet of this pattern from @MaineC, I made a proposal for what I think will be an easier to understand variant of this Patlet.

I also reviewed all of your other changes in this PR again, and they look good. Thanks again for your help here!

Once you confirm that this looks ok, then I will merge these changes (FYI I will create a new PR for this, as we need the changes to be merged into the main branch, rather than the spell-check-action branch).

Co-authored-by: Sebastian Spier <github@spier.hu>

@AlexAndradeNet AlexAndradeNet left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the suggestions

spier added a commit that referenced this pull request Jul 5, 2021
@spier spier mentioned this pull request Jul 5, 2021
@spier

spier commented Jul 5, 2021

Copy link
Copy Markdown
Member

@spier spier closed this Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants