looks great! could you also add a test, please?

hey @flying-sheep yup i'll add a test, haven't had time to get around to it :(

no probs, thank you for tackling this!

@flying-sheep turns out jupyter_kernel_test doesn't even support stop_on_error :sigh:, i filed an issue with them, but in the mean time the testing here is blocked on that

blocked on jupyter/jupyter_kernel_test#32

this is actually no problem as i’m sick ATM and couldn’t properly review this anyway 😉

Oh! This has been totally forgotten, sorry!

Let’s see if this passes travis, I’ll close and reopen

OK, I rebased this on master, let’s see if it passes travis now!

That couldn’t have worked: _execute_code checks the result. I pushed a commit that just uses execute_helper to expose what actual problems exist.

/edit: the test fails. the status is not abort.

@flying-sheep sorry this has fallen by the wayside. not a huge deal for me anymore, so feel free to close it

Well, if you have any idea why it doesn’t work, it would be appreciated. I’d prefer to improve IRkernel!