{{ message }}
Repository navigation
Performance optimizations in copy_from_non_confidential_memory - #142
Open
wojciechozga wants to merge 1 commit into
Open
wojciechozga wants to merge 1 commit into
wojciechozga wants to merge 1 commit into
Conversation
Signed-off-by: Wojciech Ozga <woz@zurich.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description of the changes
During confidential VM creation, PageTable::copy_from_non_confidential_memory recursively traverses and copies the hypervisor's page table hierarchy into confidential memory, constructing the logical_representation for each page table level (up to 512 entries per page). Previously, building the entry list using .map(...).collect::Result<Vec, Error>>()? caused Rust's internal ResultShunt to report a lower size hint of 0 due to potential error short-circuiting. Consequently the vector started with capacity 0 and was repeatedly resized and reallocated on the heap as entries were processed. Because copy_from_non_confidential_memory runs recursively across every page table in the VM's address space, these redundant reallocations added noticeable latency to VM initialization and memory setup.
This PR replaced the map().collect::<Result<...>>()? pattern with .try_fold(Vec::with_capacity(), ...) eliminating all intermediate reallocations.
Type of change