{{ message }}
Repository navigation
[sys] Include explicit URL ports in the Host header - #13060
Open
Arthur031221 wants to merge 1 commit into
Open
Arthur031221 wants to merge 1 commit into
Arthur031221 wants to merge 1 commit into
Conversation
Keep the request-capture socket compatible with native cleanup. Co-authored-by: Daniel <17953536+danielp96@users.noreply.github.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13031.
Users of
sys.Httpcontacting geckodriver onlocalhost:4444received HTTP 500 because the generatedHostheader omitted:4444.This builds on the patch @danielp96 posted in issue 13031.
The regression checks seven HTTP and HTTPS URL forms, including implicit ports, explicit default ports, alternate ports, and a URL without a scheme. It captures the request through a supplied socket and restores native streams before cleanup. With the original serialization line, five header assertions fail; all 14 assertions pass with this change. The original geckodriver reproduction printed
ERRORandHttp Error #500before the fix, thenDATAand{"value":{"message":"","ready":true}}after it.Full unit suites passed on the interpreter, C++, Python (both outputs), PHP, Neko, JavaScript, Lua and JVM. The PHP CI entry point also passed its miscellaneous, unit and system tests.
Co-authored-by: Daniel 17953536+danielp96@users.noreply.github.com