Moved week 7,8,9 from the JavaScript repo to this repository (So JavaScript3). #1
Conversation
Merge branch 'master' of github.com:mkruijt/JavaScript3
GeorgeSapkin
left a comment
GeorgeSapkin
left a comment
There was a problem hiding this comment.
LGTM except for the links.
There was a problem hiding this comment.
Why are these and other links relative? If it's in another repo use the full URL.
| >Please help us improve and share your feedback! If you find better tutorials or links, please share them by opening a Pull Request. | ||
|
|
||
| # HackYourJavaScript | ||
| # JavaScript3 |
There was a problem hiding this comment.
Or maybe HackYourFuture JavaScript 3 instead?
|
All links seem to work fine. One thing that I sometimes found confusing is that the prereading for a lecture is to be found in the README/MAKEME of the previous lecture (hence the need for a Week 0). Can't we just have the prereading in the README of the corresponding lecture? |
|
"Can't we just have the prereading in the README of the corresponding lecture?" yes, we can do that I also have thought about removing the makeme entirely and puttting the homework and readings all in the readme. It could be that in some cases the file would become quite big. For the content wise remarks, could you please create an issue, I rather solve one problem at a time :) |
|
Oh and if i'm correct the error handeling is partly covered here: https://github.com/HackYourFuture/debugging, merging this repo with the javascript assignments is the next thing on my todo list 💃 |
|
|
remarcmij
left a comment
remarcmij
left a comment
There was a problem hiding this comment.
I need to make further changes here. Let's work with relative paths for now until we find a better solution.
mkruijt
dismissed
GeorgeSapkin’s stale review
Hi George, we have to work with this repo. Like Jim said, let's work with relative paths for now until we find a better solution. I'm going to merge this now
3 participants
No description provided.