Fix ( Naming conventions ) link by profxed · Pull Request #52 · HackYourFuture/JavaScript1 · GitHub
Skip to content
This repository was archived by the owner on May 14, 2024. It is now read-only.

Fix ( Naming conventions ) link#52

Merged
remarcmij merged 2 commits into
HackYourFuture:masterfrom
profxed:master
Aug 15, 2018
Merged

Fix ( Naming conventions ) link#52
remarcmij merged 2 commits into
HackYourFuture:masterfrom
profxed:master

Conversation

@profxed

@profxed profxed commented Aug 15, 2018

Copy link
Copy Markdown

as #51 Naming conventions has a broken link.

Comment thread Week2/MAKEME.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this link contain a commit hash? I think the link can just be:

https://github.com/HackYourFuture/fundamentals/blob/master/fundamentals/naming_conventions.md

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha I didn't notice thank you jim.

@remarcmij remarcmij left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you Mohamad

@remarcmij remarcmij merged commit 3de511f into HackYourFuture:master Aug 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants