chore: bump sigs.k8s.io/controller-runtime/tools/setup-envtest by tiffanny29631 · Pull Request #2181 · GoogleContainerTools/config-sync · GitHub
Skip to content

chore: bump sigs.k8s.io/controller-runtime/tools/setup-envtest#2181

Open
tiffanny29631 wants to merge 1 commit into
GoogleContainerTools:mainfrom
tiffanny29631:fix-envtest-bump
Open

chore: bump sigs.k8s.io/controller-runtime/tools/setup-envtest#2181
tiffanny29631 wants to merge 1 commit into
GoogleContainerTools:mainfrom
tiffanny29631:fix-envtest-bump

Conversation

@tiffanny29631

@tiffanny29631 tiffanny29631 commented May 28, 2026

Copy link
Copy Markdown
Contributor

@google-oss-prow

Copy link
Copy Markdown

@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tiffanny29631. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates project dependencies and vendored packages, including upgrading the Go version to 1.26.0 and updating various Kubernetes and protobuf libraries. Key changes in the vendored code include: enhancing metav1.FieldsV1 to support a string-backed representation using unique.Handle[string]; introducing new validation utilities such as Discriminated rules, path segment name validation, and additional limit checks; adding alpha support for sharded list and watch features via ShardSelector and ShardInfo; refactoring network helpers to support contextual logging with klog.Logger; and adding a fixed-size circular buffer TypedRingFixed in k8s.io/utils. All of the reviewer's comments were filtered out as they pertained to version numbers in configuration files, so we have no further feedback to provide.

@tiffanny29631 tiffanny29631 force-pushed the fix-envtest-bump branch 2 times, most recently from 4d9c4a5 to aed3a2f Compare June 30, 2026 21:46
@tiffanny29631

Copy link
Copy Markdown
Contributor Author

Closes #2177

@tiffanny29631

Copy link
Copy Markdown
Contributor Author

@tiffanny29631 tiffanny29631 marked this pull request as ready for review June 30, 2026 23:29
@google-oss-prow google-oss-prow Bot requested review from cowsking and janetkuo June 30, 2026 23:29
@tiffanny29631 tiffanny29631 removed the request for review from janetkuo June 30, 2026 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant