appengine/flexible/pubsub: init publisher client globally by anguillanneuf · Pull Request #3280 · GoogleCloudPlatform/python-docs-samples · GitHub
Skip to content

appengine/flexible/pubsub: init publisher client globally#3280

Merged
anguillanneuf merged 4 commits into
masterfrom
anguillanneuf-patch-1
Apr 3, 2020
Merged

appengine/flexible/pubsub: init publisher client globally#3280
anguillanneuf merged 4 commits into
masterfrom
anguillanneuf-patch-1

Conversation

@anguillanneuf

@anguillanneuf anguillanneuf commented Apr 3, 2020

Copy link
Copy Markdown
Member

Closed #3259

@anguillanneuf anguillanneuf requested a review from a team as a code owner April 3, 2020 21:23
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 3, 2020
@anguillanneuf anguillanneuf mentioned this pull request Apr 3, 2020
Closed
leahecole
leahecole approved these changes Apr 3, 2020
View reviewed changes

@leahecole leahecole left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as @hongalex is ok with it and the tests are green, lgtm

@leahecole leahecole requested a review from hongalex April 3, 2020 21:56
@anguillanneuf anguillanneuf merged commit efe5e78 into master Apr 3, 2020
@anguillanneuf anguillanneuf deleted the anguillanneuf-patch-1 branch April 3, 2020 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leahecole leahecole leahecole approved these changes
@hongalex hongalex hongalex approved these changes

Assignees

@leahecole leahecole

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Google Cloud SDK pub/sub sample memory leak

4 participants

@anguillanneuf @leahecole @hongalex @googlebot