{{ message }}
fix: Add logger dependency to gemspec#227
Open
jgarber623 wants to merge 2 commits into
Open
Conversation
The functions_framework gem requires the logger gem in `lib/functions_framework/cli.rb`. Under Ruby 3.4, this emits a warning: > logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. > You can add logger to your Gemfile or gemspec to silence this warning. This commit adds the logger gem as a dependency to the gemspec which should silence the warning message. See-also: https://rubygems.org/gems/logger
Author
sambostock
reviewed
Nov 12, 2025
GoogleCloudPlatform#227 feedback Co-authored-by: Sam Bostock <bostocksamuel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functions_framework gem requires the logger gem in
lib/functions_framework/cli.rb. Under Ruby 3.4, this emits a warning:This commit adds the logger gem as a dependency to the gemspec which should silence the warning message.