feat: improve error message for CloudEvent by coryan · Pull Request #310 · GoogleCloudPlatform/functions-framework-cpp · GitHub
Skip to content

feat: improve error message for CloudEvent#310

Merged
coryan merged 1 commit into
GoogleCloudPlatform:mainfrom
coryan:feat-improve-cloud-event-json-parsing-error-message
Aug 12, 2021
Merged

feat: improve error message for CloudEvent#310
coryan merged 1 commit into
GoogleCloudPlatform:mainfrom
coryan:feat-improve-cloud-event-json-parsing-error-message

Conversation

@coryan

@coryan coryan commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

When parsing CloudEvents in JSON format the error message was a bit
obscure, it indicated that a field was missing, but not which one. This
is more readable in the common case.

When parsing CloudEvents in JSON format the error message was a bit
obscure, it indicated that a field was missing, but not which one. This
is more readable in the common case.
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2021
@coryan coryan marked this pull request as ready for review August 12, 2021 15:49
@coryan coryan requested a review from a team as a code owner August 12, 2021 15:49
@codecov

codecov Bot commented Aug 12, 2021

Copy link
Copy Markdown

@coryan coryan merged commit e283cf9 into GoogleCloudPlatform:main Aug 12, 2021
@coryan coryan deleted the feat-improve-cloud-event-json-parsing-error-message branch August 12, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants