ci: create build for MSVC by coryan · Pull Request #290 · GoogleCloudPlatform/functions-framework-cpp · GitHub
Skip to content

ci: create build for MSVC#290

Merged
coryan merged 1 commit into
GoogleCloudPlatform:mainfrom
coryan:ci-create-build-for-msvc
Feb 20, 2021
Merged

ci: create build for MSVC#290
coryan merged 1 commit into
GoogleCloudPlatform:mainfrom
coryan:ci-create-build-for-msvc

Conversation

@coryan

@coryan coryan commented Feb 20, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 20, 2021
@coryan coryan mentioned this pull request Feb 20, 2021
Merged
@codecov

codecov Bot commented Feb 20, 2021 •
edited
Loading

Copy link
Copy Markdown

@coryan
ci: add a build for MSVC 2019
2d43a5d 
Just a single static build for now, enough to verify we are not breaking
vcpkg and that the framework compiles. It uses
`FUNCTIONS_FRAMEWORK_CPP_TEST_EXAMPLES=OFF` to reduce the build times,
mostly that avoids `gRPC`, `protobuf`, and `google-cloud-cpp`.
@coryan coryan marked this pull request as ready for review February 20, 2021 18:28
@coryan coryan requested a review from a team as a code owner February 20, 2021 18:28
@coryan coryan merged commit 274ce48 into GoogleCloudPlatform:main Feb 20, 2021
@coryan coryan deleted the ci-create-build-for-msvc branch February 20, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@devbww devbww devbww approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@coryan @devbww