feat: convert storage Pub/Sub events by coryan · Pull Request #273 · GoogleCloudPlatform/functions-framework-cpp · GitHub
Skip to content

feat: convert storage Pub/Sub events#273

Merged
coryan merged 3 commits into
GoogleCloudPlatform:mainfrom
coryan:feat-simulate-storage-cloud-events
Feb 19, 2021
Merged

feat: convert storage Pub/Sub events#273
coryan merged 3 commits into
GoogleCloudPlatform:mainfrom
coryan:feat-simulate-storage-cloud-events

Conversation

@coryan

@coryan coryan commented Feb 18, 2021

Copy link
Copy Markdown
Contributor

At the moment there is no way to deliver storage notifications in
CloudEvent format for a function deployed in Cloud Run. This change adds
a shim to parse Pub/Sub messages created by storage notifications as if
they were storage events.

Part of the work for #100

@codecov

codecov Bot commented Feb 18, 2021

Copy link
Copy Markdown

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2021
At the moment there is no way to deliver storage notifications in
CloudEvent format for a function deployed in Cloud Run. This change adds
a shim to parse Pub/Sub messages created by storage notifications as if
they were storage events.
@coryan coryan marked this pull request as ready for review February 19, 2021 02:22
@coryan coryan requested a review from a team as a code owner February 19, 2021 02:22
Comment thread google/cloud/functions/internal/parse_cloud_event_storage_test.cc Outdated
Comment thread google/cloud/functions/internal/parse_cloud_event_storage_test.cc Outdated
Comment thread google/cloud/functions/internal/parse_cloud_event_storage_test.cc Outdated
@coryan coryan merged commit d0fe67b into GoogleCloudPlatform:main Feb 19, 2021
@coryan coryan deleted the feat-simulate-storage-cloud-events branch February 19, 2021 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants