iframe-proxy

gpunto · 2026-10-13T15:41:52Z

Goal

First step of moving the REST calls to the v2 endpoints: app settings, roles, devices, push preferences, OG, users, blocks, live locations, guest, polls, poll votes and user groups. The websocket stays on v1.

Part of AND-1637

Implementation

buildV2RetrofitApi builds these APIs on /api/v2/... paths with the generated Serializer for bodies. Errors keep the v1 envelope, so interceptors and the call adapter are unchanged.
Poll votes move under /api/v2/chat/messages/....
v2 sends some declared user fields only as typed fields that v1 also kept in custom. withDeclared adds them back to extraData, so both lanes map to the same User.
A user's push devices can be stored in their custom data under devices. v1 responses hide that copy; v2 returns it. The user mappers now drop it from extraData, and it is no longer sent in the user upsert or the connect user_details.

Testing

V2LaneBatchOneTest, V2LaneBatchTwoTest and V2LaneBatchThreeTest parse v2 responses and serialize v2 requests for every moved endpoint.
DomainMappingTest, DtoMappingTest and SocketFactoryTest cover the devices copy on reads, the upsert and connect.
Device probes of the moved endpoints on the compose sample, checking the wire payloads and the mapped results.
Device probe of the devices handling: a user seeded with a stored devices copy (returned by v2) maps without it, updateUser and connectUser with a devices key in extraData send other custom keys but not devices, and nothing is stored under it.

Summary by CodeRabbit

Compatibility
- Updated app settings, devices, guests, roles, polls, push preferences, user groups, users, and link-preview requests to use the v2 API.
Bug Fixes
- Prevented device data from appearing as duplicate user custom data in responses, requests, and socket connections.
- Preserved selected user fields in custom data when they are not already present, including deletion and ban details.

…endpoints

…nd writes

github-actions · 2026-10-13T15:42:05Z

github-actions · 2026-10-13T15:51:38Z

SDK Size Comparison 📏

SDK	Before	After	Status
stream-chat-android-client	6.21 MB	6.21 MB	🟢
stream-chat-android-ui-components	11.52 MB	11.52 MB	🟢
stream-chat-android-compose	13.19 MB	13.20 MB	🟢
stream-chat-android-ai-compose	2.04 MB	2.04 MB	🟢
stream-chat-android-ai-ondevice	1.67 MB	1.67 MB	🟢

coderabbitai · 2026-10-14T07:38:15Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: 1e848c5a-f7ac-451c-a703-f597bfd347c8

📥 Commits

Reviewing files that changed from the base of the PR and between a445081 and 5ce845c.

📒 Files selected for processing: 19

stream-chat-android-client/src/main/java/io/getstream/chat/android/client/api2/endpoint/ConfigApi.kt
stream-chat-android-client/src/main/java/io/getstream/chat/android/client/api2/endpoint/DeviceApi.kt
stream-chat-android-client/src/main/java/io/getstream/chat/android/client/api2/endpoint/GuestApi.kt
stream-chat-android-client/src/main/java/io/getstream/chat/android/client/api2/endpoint/OpenGraphApi.kt
stream-chat-android-client/src/main/java/io/getstream/chat/android/client/api2/endpoint/PollsApi.kt
stream-chat-android-client/src/main/java/io/getstream/chat/android/client/api2/endpoint/PushPreferencesApi.kt
stream-chat-android-client/src/main/java/io/getstream/chat/android/client/api2/endpoint/RoleApi.kt
stream-chat-android-client/src/main/java/io/getstream/chat/android/client/api2/endpoint/UserApi.kt
stream-chat-android-client/src/main/java/io/getstream/chat/android/client/api2/endpoint/UserGroupApi.kt
stream-chat-android-client/src/main/java/io/getstream/chat/android/client/api2/mapping/DomainMapping.kt
stream-chat-android-client/src/main/java/io/getstream/chat/android/client/api2/mapping/DtoMapping.kt
stream-chat-android-client/src/main/java/io/getstream/chat/android/client/di/ChatModule.kt
stream-chat-android-client/src/main/java/io/getstream/chat/android/client/socket/SocketFactory.kt
stream-chat-android-client/src/test/java/io/getstream/chat/android/client/api2/mapping/DomainMappingTest.kt
stream-chat-android-client/src/test/java/io/getstream/chat/android/client/api2/mapping/DtoMappingTest.kt
stream-chat-android-client/src/test/java/io/getstream/chat/android/client/socket/SocketFactoryTest.kt
stream-chat-android-client/src/test/java/io/getstream/chat/android/network/infrastructure/V2LaneBatchOneTest.kt
stream-chat-android-client/src/test/java/io/getstream/chat/android/network/infrastructure/V2LaneBatchThreeTest.kt
stream-chat-android-client/src/test/java/io/getstream/chat/android/network/infrastructure/V2LaneBatchTwoTest.kt

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

📝 Walkthrough

Selected API endpoints now use v2 paths and a v2 Retrofit configuration. User mappings exclude device data from custom extra data and restore selected declared fields when eligible. Request and socket user details also filter device data. Tests cover v2 response parsing, request serialization, and user data mapping.

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to 5ce84

The migrated requests use the intended v2 body serialization, and no outstanding issue has been established that would prevent merging after normal checks.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 20.41% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 98 functions across 19 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description check		The description includes the required Goal, Implementation, and Testing sections. It clearly explains the endpoint migration, mapping changes, and test coverage. The Checklist section is missing, but …
Title check		The title clearly describes a significant part of the change by naming the migration of app settings, users, and polls to v2 endpoints. It does not mention all migrated APIs, but it remains concise an…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Fix all pre-merge checks with AI

✨ Finishing Touches: 💡 1

📝 Generate docstrings: 💡

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{A rabbit checks the routes at night
V2 paths now point just right
Device data hops from custom’s store
Declared fields return once more
Tests greet each mapping, clear and bright
Then bunny bounds beyond the byte}

_{Comment @coderabbitai help to get the list of available commands.}

andremion

One question on the devices handling and a small cleanup nit.

…only devices

… stored custom copy

…he user models leave out

sonarqubecloud · 2026-10-15T07:22:25Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

andremion

LGTM, thanks for the follow-ups.

stream-public-bot · 2026-10-16T15:20:50Z

gpunto added 4 commits October 13, 2026 17:09

Move app settings, roles, devices, push preferences and og to the v2 …

c34ed52

…endpoints

Move users, blocks, live locations and guest to the v2 endpoints

1ec7dc9

Move polls, poll votes and user groups to the v2 endpoints

a92de84

Drop the devices copy stored in user custom data from v2 user reads a…

5ce845c

…nd writes

gpunto added the pr:internal Internal changes / housekeeping label Oct 13, 2026

gpunto marked this pull request as ready for review October 14, 2026 07:31

gpunto requested a review from a team as a code owner October 14, 2026 07:31

gpunto enabled auto-merge October 14, 2026 09:24

andremion reviewed Oct 14, 2026

View reviewed changes

Comment thread ...-android-client/src/main/java/io/getstream/chat/android/client/api2/mapping/DomainMapping.kt

Comment thread stream-chat-android-client/src/main/java/io/getstream/chat/android/client/di/ChatModule.kt

gpunto added 3 commits October 14, 2026 18:08

Drop every custom value stored under a declared user field name, not …

b15c713

…only devices

Fill the full user's declared extraData keys from the fields, never a…

78b3acb

… stored custom copy

Also drop custom values stored under the backend user record fields t…

ec3fc0f

…he user models leave out

andremion approved these changes Oct 15, 2026

View reviewed changes

gpunto added this pull request to the merge queue Oct 15, 2026

Merged via the queue into develop with commit 75eb711 Oct 15, 2026
19 checks passed

gpunto deleted the migrate/v2-lane-1-config-users-polls branch October 15, 2026 08:28

gpunto mentioned this pull request Oct 15, 2026

Move threads, drafts and reminders to the v2 endpoints #6828

Merged

andremion mentioned this pull request Oct 15, 2026

Stop sending the user's devices in outgoing user payloads #6825

Merged

stream-public-bot added the released Included in a release label Oct 16, 2026

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Repository navigation

Move app settings, users and polls to the v2 endpoints - #6821

Move app settings, users and polls to the v2 endpoints#6821
gpunto merged 7 commits into
developfrom
migrate/v2-lane-1-config-users-polls

gpunto commented Oct 13, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

github-actions Bot commented Oct 13, 2026

Uh oh!

github-actions Bot commented Oct 13, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 14, 2026

Uh oh!

andremion left a comment

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Oct 15, 2026

Uh oh!

andremion left a comment

Uh oh!

Uh oh!

stream-public-bot commented Oct 16, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

gpunto commented Oct 13, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Goal

Implementation

Testing

Summary by CodeRabbit

Uh oh!

github-actions Bot commented Oct 13, 2026

PR checklist ✅

Uh oh!

github-actions Bot commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SDK Size Comparison 📏

Uh oh!

coderabbitai Bot commented Oct 14, 2026

Uh oh!

andremion left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Oct 15, 2026

Quality Gate passed

Uh oh!

andremion left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stream-public-bot commented Oct 16, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gpunto commented Oct 13, 2026 •

edited by coderabbitai Bot

Loading

github-actions Bot commented Oct 13, 2026 •

edited

Loading