Repository navigation
Keep the size of an uploaded attachment when the uploader deletes its file - #6809
Conversation
SDK Size Comparison 📏
|
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to No actionable issue was identified that would prevent merging after normal checks. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 57.14% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 2 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
Check name Status Explanation Title check The title clearly describes the main fix: preserving an uploaded attachment's size when the uploader deletes the file. Description check The description includes the goal, implementation, issue reference, and testing details. The omitted UI and checklist sections are not critical for this non-UI change. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
-
📝 Generate docstrings 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
I’m a rabbit with a file-size note,
I watch the upload sail afloat.
Though the file hops out of sight,
Its measured bytes arrive just right.
I twitch my nose and softly cheer,
The size stays safe from start to clear.
Comment @coderabbitai help to get the list of available commands.
3 participants
Goal
AttachmentUploaderread an uploaded file's size after theFileUploaderreturned. A custom uploader that deletes the file once it's uploaded made the attachment go out withfile_size: 0.Closes AND-1643
Port of #6808 to
develop.Implementation
FileTransformer) is read before the upload and used for the uploaded attachment.Testing
AttachmentUploaderTestscovers an uploader that deletes the file during the upload.On an emulator (on
v6, where the code is the same), with a custom uploader that deletes each file before returning success: the server storedfile_size: 0for a file, an audio and an image attachment; with the fix, it stores the right sizes.🤖 Generated with Claude Code
Summary by CodeRabbit