{{ message }}
Repository navigation
Migrate the socket hello and keep-alive to the generated event models - #6797
Merged
Merged
Conversation
Contributor
Contributor
SDK Size Comparison 📏
|
gpunto
force-pushed
the
migrate/socket-hello-mutes-events
branch
from
October 9, 2026 07:32
d606470 to
7b82516
Compare
gpunto
force-pushed
the
migrate/socket-hello-mutes-events
branch
from
October 9, 2026 11:35
7b82516 to
cabf306
Compare
|
gpunto
marked this pull request as ready for review
October 12, 2026 07:36
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to No confirmed issue prevents merging after normal checks. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 15 functions across 7 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
Check name Status Explanation Title check The title clearly and concisely describes the primary change: migrating socket hello and keep-alive handling to generated event models. Description check The description includes the goal, implementation details, issue reference, and relevant unit and device testing. UI sections and checklists are omitted, but they are not critical for this non-UI chan… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
-
📝 Generate docstrings 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
I’m a rabbit, ears held high,
New socket events hop by.
Connected frames land neat and clear,
Health-check fields appear.
Tests inspect each JSON clue,
Then I nibble carrots too.
Comment @coderabbitai help to get the list of available commands.
andremion
approved these changes
Oct 12, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Parse the socket hello and keep-alive (both
health.check) with the generated event models.Part of AND-1291
Implementation
ConnectedEventandHealthCheckEvent, and deleteConnectedEventDtoandHealthEventDto.health.checkcarryingmestill maps toConnectedEvent, and any otherhealth.checktoHealthEvent.Testing
GeneratedSocketEventParsingTestmaps the hello and the keep-alive, and rejects either one missing a required field, as well as a hello whose user misses one. The mapping tests cover every field.On a device: reconnected the socket and checked the hello's connection id, timestamp and current user, and that the client took its connection id. The socket then stayed up on keep-alives for 45 seconds without reconnecting.
🤖 Generated with Claude Code
Summary by CodeRabbit