{{ message }}
Repository navigation
Migrate the AI indicator and added to channel events to the generated event models - #6794
Merged
Merged
Conversation
Contributor
Contributor
SDK Size Comparison 📏
|
gpunto
force-pushed
the
migrate/ai-indicator-added-to-channel-events
branch
from
October 8, 2026 15:00
dacddad to
1a5dd8b
Compare
gpunto
marked this pull request as ready for review
October 8, 2026 15:26
gpunto
enabled auto-merge
October 8, 2026 15:26
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (10)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review. WalkthroughThe event parser now represents notification-added-to-channel and AI indicator update, clear, and stop events with generated WebSocket models. Adapters enforce required fields, and event mapping derives channel identifiers from ChangesGenerated event parsing
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Refactor Sequence Diagram(s)sequenceDiagram
participant EventAdapter
participant GeneratedEventDto
participant EventMapping
participant ChatEvent
EventAdapter->>GeneratedEventDto: Parse generated WebSocket event
GeneratedEventDto->>EventMapping: Dispatch event model
EventMapping->>ChatEvent: Map to domain event
Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable issue is established for the event-parsing migration; it is mergeable after normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the event stream’s glow, Comment |
gpunto
force-pushed
the
migrate/ai-indicator-added-to-channel-events
branch
from
October 9, 2026 07:32
1a5dd8b to
088386f
Compare
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Parse the
ai_indicator.update,ai_indicator.clear,ai_indicator.stopandnotification.added_to_channelevents with the generated event models.Part of AND-1291
Implementation
AIIndicatorUpdateEvent,AIIndicatorClearEvent,AIIndicatorStopEventandNotificationAddedToChannelEventas they are, and delete the hand-written DTOs.notification.added_to_channelmaps to 0, as before.Testing
GeneratedAIIndicatorEventParsingTestparses each AI indicator event and rejects one missing a required field.GeneratedNotificationEventParsingTestcoversnotification.added_to_channel, including zero unread counts. The mapping tests cover every field.On a device: received the three AI indicator events and
notification.added_to_channelover the socket, and parsednotification.added_to_channelreplayed by/sync.🤖 Generated with Claude Code
Summary by CodeRabbit