{{ message }}
Repository navigation
row 159: ledger, crates/busbar-core-admin/src fixed at 85e59fc5fc (5 HIGH closed on dev) - #1491
Merged
Merged
Conversation
The five HIGH findings of the round-2 audit (565f24f) are closed on dev: - static rate seam: USAGE_RATE_HISTORY removed; the read takes the kernel's dated history (v1/service.rs dated_rate_history) - plane-kind plugin: a70a10b removed the AdminPlane Plugin/PlaneMeta face - money summing: #1318 routes the usage rollups through the ledger's cost::sum_spend - rotation ceiling: rotate_key now asks mint_policy.check_mint (keys.rs) - empty admin chain: #1251 applies it with a warning, as 1.5.5 did Stamped as `cargo xtask ledger fixed --scope crates/busbar-core-admin/src --commit 85e59fc` writes it: fixed_at is the last dev commit that changed the scope, and tree_hash is the scope's tree there (its tests excluded). The scope owes a confirming round at that tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A ledger stamp only, written exactly as
cargo xtask ledger fixed --scope crates/busbar-core-admin/src --commit 85e59fc5fcwould write it:fixed_at=85e59fc5fcc5a859aa4554354dbf6c1fbd14ac6f, the last dev commit that changed the scopetree_hash=d9624046…f01caa, the sha256 of the sortedpath<TAB>blob-oidlist of the scope's files at that commit, withsrc/testsexcluded as the scope statesThe script that computes the hash reproduces the recorded audited hash at 565f24f (
90f2b67a…).Why
The round-2 audit (565f24f) recorded 5 HIGH findings. Each one is closed on dev by a change that landed after the audit, with its own RED test:
USAGE_RATE_HISTORY/install_usage_rate_historyremoved.v1/service.rs::dated_rate_historyreads the kernel's dater (R6)Plugin/PlaneMetaface. The admin surface is a cleanliness crate's route on the claim table (THE DESIGN, Cleanliness crates)cost::sum_spend/budget_remaining(BUSBAR-1.6.0.md l.1002-1003)keys.rs::rotate_keyasksmint_policy.check_mintwith the default TTL, clamped, never refusedEMPTY_CHAIN_REFUSED_LIVE = false, pending the owner's signature)The scope now reads
fixedand owes a confirming zero round from a different auditor at this tree.RED tests
They are in the PRs named above. This PR changes no code.
1.5.5 bytes
None.
Changed guarded files
qa/audit-ledger.json(guardedqa/**/*.json): needs the ModernCI coordinator's approval.