{{ message }}
docker: add docker.TYPE.IMAGE.tag to retag :latest as current SHA#5892
Open
marc-casavant wants to merge 1 commit into
Open
docker: add docker.TYPE.IMAGE.tag to retag :latest as current SHA#5892marc-casavant wants to merge 1 commit into
marc-casavant wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Profiling/multi-server images are tagged by git short SHA, and the compose envs request the image at the live SHA. But the build stamp depends only on the Dockerfile, so when HEAD moves without a Dockerfile change, the rebuild is a no-op, no :
<new-sha>tag is created, and Docker falls back to pulling the missing tag, which fails withpull access denied.This is especially common in a localhost/dev environment, where developers commit frequently (often non-Dockerfile changes) between test runs and have no registry to pull the SHA-tagged image from. The new target points the current SHA tag at the already-built
:latestimage with no rebuild (no-op if the SHA tag exists, fails loudly if nothing is built yet), plus adocker.helpline.Kept as a manual step (not wired into
freeradius-prof.image) so the developer controls when retagging happens.Usage:
make docker.profiling.ubuntu24.tagbeforemake test.multi-server.profiling.ciwhen HEAD has advanced past the last image build.