Add EnzymeRules for batchnorm by wsmoses · Pull Request #537 · FluxML/NNlib.jl · GitHub
Skip to content

Add EnzymeRules for batchnorm - #537

Open
wsmoses wants to merge 15 commits into
FluxML:masterfrom
wsmoses:batchnorm
Open

Add EnzymeRules for batchnorm#537
wsmoses wants to merge 15 commits into
FluxML:masterfrom
wsmoses:batchnorm

Conversation

@wsmoses

@wsmoses wsmoses commented Sep 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Follow up to #536

I made this a separate PR, because for efficiency sake, it is better to have an inplace version of batchnorm, but that wasn't an exported API. Thus I implemented this on the inplace cuda one (which was the only implementation of batchnorm, in place or not).

If NNlib is later refactored to have batchnorm! this can go on the refactored rule.

@mashu

mashu commented Sep 25, 2023

Copy link
Copy Markdown
Contributor

@CarloLucibello

CarloLucibello commented Oct 11, 2023

Copy link
Copy Markdown
Member

There is a weird parsing error in the Code Coverage stage

@CarloLucibello CarloLucibello reopened this Nov 2, 2023
@CarloLucibello

CarloLucibello commented Nov 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Does anyone know about the ubuntu CI error

ERROR: LoadError: Base.Meta.ParseError("parsing error in ext/NNlibCUDACUDNNExt/batchnorm.jl:253: invalid identifier name \"||\"")
Stacktrace:
 [1] amend_coverage_from_src!(fc::FileCoverage)
   @ CoverageTools ~/.julia/packages/CoverageTools/JSYpL/src/CoverageTools.jl:186

?

@CarloLucibello CarloLucibello reopened this Nov 7, 2023
@mashu

mashu commented Nov 7, 2023

Copy link
Copy Markdown
Contributor

@mcabbott mcabbott mentioned this pull request Dec 31, 2024
Closed

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Enzyme

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wsmoses @mashu @CarloLucibello @mcabbott