{{ message }}
fix: size() uses UTF-16 code units for strings#67
Merged
Conversation
jcshepherd
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Changes
size()condition expression function to use UTF-16 code unit count for strings instead of UTF-8 byte length.Why
Closes #60
DynamoDB uses UTF-16 code units for
size()on strings. ExtendDB was using Rust'sstr::len()(UTF-8 bytes), causing condition expressions to evaluate incorrectly for non-ASCII strings. For example,"é𝄞"should be size 3 (1 + 2 surrogate pair) but was returning 6.Testing done
size("é𝄞") = 3succeeds,size("é𝄞") = 6failscargo test --workspacepassescargo clippy --all-targets -- -D warningscleanChecklist
cargo test --workspace)cargo fmt --check)cargo clippy -- -W clippy::pedantic)By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache License 2.0 and I agree to the Developer Certificate of
Origin (DCO). See CONTRIBUTING.md for details.