{{ message }}
fix: resolve all clippy warnings#41
Merged
Merged
Conversation
- Replace &[x.clone()] with std::slice::from_ref(&x) (auth tests) - Fix doc comment indentation and remove orphaned doc comment - Replace mutable loop counter with computed index (index.rs) - Use struct literal initialization instead of Default + reassign (validation tests) - Add type aliases for complex return types in storage traits - Add #[allow(clippy::too_many_arguments)] for 3 internal functions - Auto-fix: remove useless format!, simplify map_or, etc. cargo clippy --all-targets -- -D warnings now passes clean.
pdf-amzn
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve all clippy warnings so
cargo clippy --all-targets -- -D warningspasses clean.Changes
&[x.clone()]withstd::slice::from_ref(&x)in auth policy evaluator testserror/mod.rsengine/src/lib.rsindex.rsDefault::default()+ field reassign in validation testsItemPairResult,QueryResult,TtlTableInfo,StreamRecordsResult,StreamListResult,UserListEntry,GroupListEntry,RoleListEntry,TableInfoRow)#[allow(clippy::too_many_arguments)]for 3 internal functions where param structs would be a larger refactorformat!, simplifymap_or, etc.Follow-up
The 3
too_many_argumentsallows should be replaced with param structs in a future PR. The type aliases could be upgraded to named structs for better self-documentation.Verification
cargo clippy --all-targets -- -D warnings— zero warningscargo test --workspace— all passcargo fmt --all -- --check— clean