{{ message }}
test: add pytest coverage for fixes from 6b98234 to c20b2d6; fix a few older tests#113
Merged
Conversation
Add 46 new integration tests covering behavioral fixes that were previously only validated by Rust unit tests or not tested at all. All tests run against both real DynamoDB and extenddb via boto3. test_query_scan.py (+22 tests): - KeyConditionExpression with parentheses - KCE must reference partition key - Undefined #name in FilterExpression - Unused ExpressionAttributeNames/Values rejection - size() on missing attribute returns None - begins_with on binary sort keys - Reserved keyword without alias - Negative Scan segment rejection - Legacy API: KeyConditions, QueryFilter, ScanFilter, AttributesToGet - Legacy/expression mutual exclusivity - LSI synchronous write verification test_item_operations.py (+19 tests): - Number validation (NaN, Infinity, >38 digits) - Unused ExpressionAttributeNames on PutItem - UpdateItem: SET list[N] beyond bounds appends - UpdateItem: missing intermediate map path rejected - UpdateItem: reserved keyword without alias - UpdateItem: empty UpdateExpression rejected - UpdateItem: condition on non-existent item - UpdateItem: <> comparison with missing attribute - DeleteItem: nonexistent table, condition on missing item - ProjectionExpression: list index, out-of-bounds index test_table_operations.py (+11 tests): - CreateTable: duplicate KeySchema, >2 elements, LSI without range key, invalid BillingMode - ListTables: alphabetical sort order - UpdateTable: PAY_PER_REQUEST with throughput, zero throughput, remove nonexistent GSI, billing mode switch test_transaction_operations.py (+2 tests): - TransactWriteItems total size > 4MB rejected - ConditionCheck with attribute_not_exists on missing item
…ests Use a new dynamodb_client_no_validation fixture (parameter_validation=False) so that invalid parameters reach the service instead of being rejected by the SDK. This matches real DynamoDB behavior for: - test_scan_negative_segment (Segment=-1) - test_update_table_zero_throughput (ReadCapacityUnits=0) - test_create_table_name_too_short (TableName='ab')
- Add _is_real_dynamodb() and _poll_interval() helpers: 200ms for real DynamoDB, 20ms for ExtendDB to avoid aggressive polling - Fix create_and_cleanup_table teardown to wait for ACTIVE then retry delete when ResourceInUseException is raised (table in UPDATING state) - Increase wait_for_active timeout to 120s and wait_for_deleted to 300s to accommodate real DynamoDB table lifecycle durations - Apply _poll_interval() to all stream polling loops in test_streams.py
LeeroyHannigan
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Better test coverage for fixes we landed recently
Why
This helps confirm that our fixes were correct
Testing done
ran new & changed pytests against DynamoDB
Checklist
cargo test --workspace)cargo fmt --check)cargo clippy -- -W clippy::pedantic) - no new clippy issuesBy submitting this pull request, I confirm that my contribution is made under
the terms of the Apache License 2.0 and I agree to the Developer Certificate of
Origin (DCO). See CONTRIBUTING.md for details.