{{ message }}
If legacy member templates are disabled, ignore member profile_trigger#5289
Draft
robinsowell wants to merge 1 commit into
Draft
If legacy member templates are disabled, ignore member profile_trigger#5289robinsowell wants to merge 1 commit into
robinsowell wants to merge 1 commit into
Conversation
Basically- legacy_member_templates set to 'n' the member profile trigger setting in the cp disappears. HOWEVER the trigger was still active and hitting it sends you to the member profile template with a message they are disabled. It doesn't help that some member tags use them as defaults. Case in point- validation error logging got the 'This page is not accessible because legacy member templates are not enabled.' Another case- forgotten password- if you don't set the return it goes to the member template reset - and throws the 'legacy not enabled' error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Basically- legacy_member_templates set to 'n' the member profile trigger setting in the cp disappears. HOWEVER the trigger was still active and hitting it sends you to the member profile template with a message they are disabled. It doesn't help that some member tags use them as defaults.
Case in point- validation error logging got the
'This page is not accessible because legacy member templates are not enabled.'
Another case- forgotten password- if you don't set the return it goes to the member template reset - and throws the 'legacy not enabled' error.
Needs testing- plus scan says:
There are still several member-tag paths that default to legacy template elements.
{exp:member:login} path:
{exp:member:forgot_password} path:
{exp:member:reset_password} path:
Registration/member profile related tag methods with “empty tagdata => legacy fallback when enabled”:
The safest modern tags are the explicit *_form variants (login_form, forgot_password_form, reset_password_form, registration_form with tagdata).
SO need to go through the docs and ponder whether this is actually a concern.