{{ message }}
7x/error display hardening alt2#5246
Open
robinsowell wants to merge 6 commits into
Open
Conversation
This was referenced Apr 28, 2026
That fixes the debug = 0 case. Before this change, a logged-in Super Admin would still get detailed PHP/exception/DB error output even when debugging was configured off. That effectively made Super Admin status an implicit “show detailed errors” override.
and consistency for the db error.
blunket
pushed a commit
to blunket/ExpressionEngine
that referenced
this pull request
Jun 4, 2026
Alternative to ExpressionEngine#5246 Non-debug + no session / member_id == 0: exits before rendering error_exception.php, so guests no longer see Exception Caught. Debug override / config debug > 1: unchanged, still shows details. Logged-in users: existing behavior preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

OK- this is frankly my preference for the error hardening.
#5244 Uses global buffering to catch server level errors we can't 100% get otherwise
#5245 ditches the buffering but can't catch all critical errors and just feels a little janky.
#5246 ditches buffering, does not try to catch all of those server errors. Does fix other EE related leaked output, but we'd note in the docs that if you want NO server errors to show, that must be done via server setting.
Compared to current 7.dev, this version is stricter for non-allowed users:
It does NOT do:
So the remaining browser exposure for critical engine fatals is exactly the server-config boundary: if PHP/server has display_errors on, PHP may show engine fatal output. This branch does not add to that; it just logs those fatals when EE reaches shutdown.