iframe-proxy

KokeroO · 2025-05-22T03:29:59Z

Descrição

Este PR adiciona a possiblidade de envio de arquivos do tipo SVG e TIFF da mesma forma que faz com do tipo GIF vindas do Chatwoot.
Atualmente o WhatsApp WEB somente aceita imagens do tipo JPG, PNG e WEBP de forma nativa, GIF e SVG o core processa as imagens em JPEG e PNG respectivamente.

Como o Chatwoot não entende que isso é um problema no canal de API deles, visto que o envio do arquivo é feito puro. Então sim, se entende ser um problema da API. Devemos tratar esses attachs na API Evolution.

Proposta

Enviar os tipos SVG e TIFF da mesma forma que atualmente é feito com as imagens do tipo GIF.

Solução

Adicionei uma constante com um array de extensões de mimetype: image e que deverão ser enviadas como tipo document. O array permite a fácil inclusão de outros tipos de imagens que poderão ser identificadas futuramente.

const documentExtensions = ['.gif', '.svg', '.tiff'];
if (type === 'image' && parsedMedia && documentExtensions.includes(parsedMedia?.ext)) {
  type = 'document';
}

Futuro

Futuramente poderíamos implementar um processador de imagens. Convertendo nos formatos aceitáveis pelo WhatsApp.

…twoot

sourcery-ai · 2025-05-22T03:30:04Z

Reviewer's Guide

This PR generalizes the media handling logic by introducing a documentExtensions array (['.gif', '.svg', '.tiff']) and updating the condition to send matching images as documents, thereby enabling SVG and TIFF support in the Chatwoot integration.

Sequence Diagram for Handling Special Image Attachments from Chatwoot

sequenceDiagram
    participant C as Chatwoot
    participant API as "ChatwootService (API)"
    participant WA as WhatsApp

    C->>+API: Send message with image (e.g., .svg, .tiff, .gif)
    API->>API: Received type: 'image', attachment_extension: ext
    alt ext is in documentExtensions ['.gif', '.svg', '.tiff']
        API->>API: Modify type: 'image' -> 'document'
        API->>+WA: Send message (type='document', media)
    else Other image types (e.g., .jpg, .png)
        API->>+WA: Send message (type='image', media)
    end
    WA-->>-API: Delivery Status
    API-->>-C: Message Status

File-Level Changes

Change	Details	Files
Extract and define a reusable list of media extensions for document mapping	Added a `documentExtensions` constant array containing ['.gif', '.svg', '.tiff']	`src/api/integrations/chatbot/chatwoot/services/chatwoot.service.ts`
Replace hardcoded GIF check with array-based condition to include SVG and TIFF	Updated the `if (type === 'image' && parsedMedia?.ext === '.gif')` to use `documentExtensions.includes(parsedMedia.ext)`	`src/api/integrations/chatbot/chatwoot/services/chatwoot.service.ts`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

KokeroO · 2025-05-22T03:30:25Z

@sourcery-ai review

sourcery-ai

Hey @KokeroO - I've reviewed your changes - here's some feedback:

Consider hoisting the documentExtensions array out of the function (or module) scope to avoid recreating it on every call and centralize configuration.
You might also want to include the common .tif extension alongside .tiff to cover both naming variants.

Here's what I looked at during the review

🟢 General issues: all looks good
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

…umentos

KokeroO · 2025-05-22T03:39:50Z

KokeroO added 2 commits May 22, 2025 03:02

chore: possibilita o envio de medias do tipo .svg

0ca109e

chore: possibilita o envio de medias do tipo svg e tiff vindas do Cha…

272a4de

…twoot

sourcery-ai Bot reviewed May 22, 2025

View reviewed changes

chore: adiciona suporte para extensão de arquivo .tif no envio de doc…

8b15c11

…umentos

DavidsonGomes merged commit 6f47a54 into EvolutionAPI:develop May 22, 2025
1 check passed

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: possibilita o envio de medias do tipo [svg, tiff] vindas do Chatwoot#1483

chore: possibilita o envio de medias do tipo [svg, tiff] vindas do Chatwoot#1483
DavidsonGomes merged 3 commits intoEvolutionAPI:developfrom
KokeroO:develop

KokeroO commented May 22, 2025 •

edited

Loading

Uh oh!

sourcery-ai Bot commented May 22, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

KokeroO commented May 22, 2025

Uh oh!

sourcery-ai Bot left a comment

Uh oh!

KokeroO commented May 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

KokeroO commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Descrição

Proposta

Solução

Futuro

Uh oh!

sourcery-ai Bot commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

Sequence Diagram for Handling Special Image Attachments from Chatwoot

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

KokeroO commented May 22, 2025

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

KokeroO commented May 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

KokeroO commented May 22, 2025 •

edited

Loading

sourcery-ai Bot commented May 22, 2025 •

edited

Loading