iframe-proxy

pedro-php · 2025-03-25T14:13:35Z

Fix

Problema

Ao enviar uma mensagem via dispositivo, dois comportamentos distintos ocorriam:

Inicialmente, o evento MESSAGES_UPSERT atualizava o campo name da tabela Chat com o pushname do remetente.
Em seguida, o evento MESSAGES_UPDATE sobrescrevia o campo name com uma string vazia de forma consistente, pois tentava fazer um update utilizando uma variável que sequer era definida — já que esse campo não era enviado pelo respectivo evento da Baileys.

O que foi alterado?

O campo name da tabela Chat não é mais atualizado durante o evento MESSAGES_UPDATE.
No evento MESSAGES_UPSERT, o campo name só é atualizado quando fromMe for falso, ou seja, apenas quando a mensagem for recebida (não enviada pelo próprio usuário).

Resolução

Agora, ao chamar um endpoint que retorna o campo name da tabela Chat (como o /chat/findChats/), o valor retornado será o correto — evitando strings vazias ou o nome do próprio remetente. O campo continua sendo atualizado normalmente ao receber mensagens.

sourcery-ai · 2025-03-25T14:13:40Z

Reviewer's Guide by Sourcery

This pull request fixes a bug in the findChats endpoint and implements pagination for the findChats and findContacts endpoints. The bug fix ensures that the correct chat name is returned, while the pagination feature improves performance for users with many contacts and chats.

Sequence diagram for fetching chat name

sequenceDiagram
  participant Client
  participant ChannelStartupService
  participant PrismaRepository

  Client->>ChannelStartupService: Calls findChats endpoint
  ChannelStartupService->>PrismaRepository: Executes raw SQL query to fetch chats
  PrismaRepository-->>ChannelStartupService: Returns chat data including chatName from Chat table
  ChannelStartupService-->>Client: Returns chat data with correct chatName

Sequence diagram for Contact Pagination

sequenceDiagram
    participant Client
    participant ChannelStartupService
    participant PrismaRepository

    Client->>ChannelStartupService: Calls findContacts endpoint with page and offset
    ChannelStartupService->>PrismaRepository: Calls contact.findMany with take and skip parameters
    PrismaRepository-->>ChannelStartupService: Returns paginated contact data
    ChannelStartupService-->>Client: Returns paginated contact data

Updated class diagram for ChannelStartupService

classDiagram
    class ChannelStartupService {
        +findContacts(query: any): Promise<Contact[]>
        +findChats(query: any): Promise<Chat[]>
    }

    class Contact {
        id: string
        remoteJid: string
        pushName: string
        chatName: string
        profilePicUrl: string
        updatedAt: Date
        windowStart: Date
    }

    note for Contact "Added chatName attribute"

    class Chat {
        name: string
        createdAt: Date
    }

    ChannelStartupService -- Contact : returns

File-Level Changes

Change	Details	Files
Fixed a bug in the `findChats` endpoint that was returning the push name of the last user who sent a message in the chat instead of the chat name itself.	The chat name is no longer overwritten with the sender's push name in messages from groups. Added a `chatName` parameter to the endpoint's return, which returns the chat name from the `Chats` table.	`src/api/services/channel.service.ts` `src/api/integrations/channel/whatsapp/whatsapp.baileys.service.ts`
Implemented pagination for the `findChats` and `findContacts` endpoints.	Added the ability to paginate the `findChats` and `findContacts` endpoints using the `page` and `offset` parameters. In the `findChats` endpoint, pagination was added directly to the raw query. In the `findContacts` endpoint, pagination was added to the `take` and `skip` parameters of Prisma.	`src/api/services/channel.service.ts`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!
Generate a plan of action for an issue: Comment @sourcery-ai plan on
an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey @pedro-php - I've reviewed your changes - here's some feedback:

Overall Comments:

Consider adding validation to ensure that page and offset are positive integers.
It might be worth extracting the pagination logic into a separate helper function to improve readability.

Here's what I looked at during the review

🟡 General issues: 1 issue found
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

MateusHirataAW · 2025-03-25T16:31:03Z

up

marcosgalupo · 2025-03-25T16:45:31Z

fix_and_add_name_to_find_chats_and_paginate_get_contacts_and_get_chats

c5c354f

sourcery-ai Bot reviewed Mar 25, 2025

View reviewed changes

Comment thread src/api/services/channel.service.ts Outdated

Update src/api/services/channel.service.ts

d196590

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

DavidsonGomes changed the base branch from main to develop March 26, 2025 12:59

DavidsonGomes merged commit b89f114 into EvolutionAPI:develop Mar 26, 2025
1 check passed

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Corrigindo um bug no endpoint de findChats e permitindo paginação nos endpoints de findChats e findContacts#1334

Corrigindo um bug no endpoint de findChats e permitindo paginação nos endpoints de findChats e findContacts#1334
DavidsonGomes merged 2 commits intoEvolutionAPI:developfrom
adaptwebtech:fix_and_add_name_to_find_chats_and_paginate_get_contacts_and_get_chats

pedro-php commented Mar 25, 2025 •

edited

Loading

Uh oh!

sourcery-ai Bot commented Mar 25, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai Bot left a comment

Uh oh!

Uh oh!

MateusHirataAW commented Mar 25, 2025

Uh oh!

marcosgalupo commented Mar 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

pedro-php commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fix

Problema

O que foi alterado?

Resolução

Uh oh!

sourcery-ai Bot commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide by Sourcery

Sequence diagram for fetching chat name

Sequence diagram for Contact Pagination

Updated class diagram for ChannelStartupService

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MateusHirataAW commented Mar 25, 2025

Uh oh!

marcosgalupo commented Mar 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pedro-php commented Mar 25, 2025 •

edited

Loading

sourcery-ai Bot commented Mar 25, 2025 •

edited

Loading