Implement smooth scrolling in OuiMainMenu by DashingCat · Pull Request #1049 · EverestAPI/Everest · GitHub
Skip to content

Implement smooth scrolling in OuiMainMenu - #1049

Merged
SnipUndercover merged 1 commit into
EverestAPI:devfrom
DashingCat:implement-smooth-scrolling-in-ouimainmenu
May 12, 2026
Merged

SnipUndercover merged 1 commit into
EverestAPI:devfrom
DashingCat:implement-smooth-scrolling-in-ouimainmenu

Conversation

@DashingCat

Copy link
Copy Markdown
Contributor

Follow-up on #880 (review), this PR implements a smooth scrolling for buttons in the OuiMainMenu.

@maddie480-bot maddie480-bot added the 1: review needed This PR needs 2 approvals to be merged (bot-managed) label Dec 28, 2025
@DashingCat
DashingCat force-pushed the implement-smooth-scrolling-in-ouimainmenu branch from baf9f7c to 08484cd Compare December 28, 2025 19:35

@Wartori54 Wartori54 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, havent tested yet though.
Small nitpick: point out in a comment where that smoothing constant comes from.

@DashingCat
DashingCat force-pushed the implement-smooth-scrolling-in-ouimainmenu branch 2 times, most recently from 94ad1c8 to 0255acd Compare March 15, 2026 22:05
@DashingCat

Copy link
Copy Markdown
Contributor Author

@DashingCat
DashingCat requested a review from Wartori54 March 15, 2026 22:09
@DashingCat
DashingCat force-pushed the implement-smooth-scrolling-in-ouimainmenu branch from 0255acd to 8aa192b Compare March 15, 2026 22:10

@microlith57 microlith57 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@maddie480-bot

Copy link
Copy Markdown
Member

The pull request was approved and entered the 3-day last-call window.
If no further reviews happen, it will end on May 12, 2026, 12:10 AM UTC, after which the pull request will be able to be merged.

@maddie480-bot maddie480-bot added 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) and removed 1: review needed This PR needs 2 approvals to be merged (bot-managed) labels May 9, 2026
@maddie480-bot

Copy link
Copy Markdown
Member

@maddie480-bot maddie480-bot added 4: ready to merge This PR was approved and the last-call window is over (bot-managed) and removed 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) labels May 12, 2026
@SnipUndercover
SnipUndercover merged commit a311207 into EverestAPI:dev May 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: ready to merge This PR was approved and the last-call window is over (bot-managed)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants