iframe-proxy

DashingCat · 2025-12-10T22:57:53Z

This PR adds a workspace folder to the MiniInstaller installation process, so it doesn't overwrite Celeste.exe early (for example, during the step applying Everest patches, after coreification).

The workspace is used to store the Celeste.exe/Celeste.dll files, until after the step applying Everest patches, reducing the time window during which the process can be interrupted and left in a state which would allow orig/Celeste.exe to be coreified.

This is a work in progress, the following still needs to be done:

Testing on Windows
Testing on MacOS
Applying the changes to MiniInstaller's "FastMode" (not needed)

Fixes #983.
Fixes #984.
As far as I understand, #984 occurs only because of #983.

Wartori54

Just some polish needed here and there.
About your fast mode question, I'd be fine with merging without any changes to fast mode, it is meant for advanced users only, so if the installation breaks the user will notice that and be able to fix it.

DashingCat · 2025-12-17T23:57:40Z

Wartori54

Other than this LGTM. Would appreciate some testing on other platforms before merging though.

DashingCat · 2025-12-18T22:45:09Z

The latest commit uses Path.PathSeparator instead of :.

microlith57

code looks good, just a few missing param names (non-blocking). still would be good to test on windows/macos :p

microlith57 · 2026-01-02T23:53:49Z

    public static void MoveExecutable(string srcPath, string dstPath) {
-        File.Delete(dstPath);
-        File.Move(srcPath, dstPath);
+        File.Move(srcPath, dstPath, true);


nitpick: (for readability)

Suggested change

File.Move(srcPath, dstPath, true);

File.Move(srcPath, dstPath, overwrite: true);

(& similarly for the other File.Move calls below)

microlith57 · 2026-01-02T23:54:23Z

        string steamworksLibDst = Path.Combine(Globals.PathGame, "Steamworks.NET.dll");
-        File.Delete(steamworksLibDst);
-        File.Copy(steamworksLibSrc, steamworksLibDst);
+        File.Copy(steamworksLibSrc, steamworksLibDst, true);


nitpick: (for readability)

Suggested change

File.Copy(steamworksLibSrc, steamworksLibDst, true);

File.Copy(steamworksLibSrc, steamworksLibDst, overwrite: true);

microlith57 · 2026-01-02T23:55:17Z


+                if (Directory.Exists(Globals.PathMiniInstallerWorkspace)) {
+                    Logger.LogLine("MiniInstaller workspace already exists, cleaning before continuing.");
+                    Directory.Delete(Globals.PathMiniInstallerWorkspace, true);


nitpick: (readability)

Suggested change

Directory.Delete(Globals.PathMiniInstallerWorkspace, true);

Directory.Delete(Globals.PathMiniInstallerWorkspace, recursive: true);

(& similarly for the other recursive Directory.Delete)

maddie480-bot · 2026-01-03T00:10:12Z

The pull request was approved and entered the 3-day last-call window.
If no further reviews happen, it will end on Jan 6, 2026, 12:08 AM UTC, after which the pull request will be able to be merged.

SnipUndercover

Adding a "request changes" review just so that this doesn't get accidentally merged without testing, will turn into an approval when it's done.

DashingCat · 2026-01-08T18:50:52Z

Parameter names have been added in the latest commit.

SnipUndercover

Code-wise looks good, but upon testing MiniInstaller crashes when patching FNA. It attempts to resolve the Celeste assembly, but it finds Celeste.exe which is a Piton apphost on already modded installs. MonoMod then tries to read that as a managed .NET assembly and promptly crash.

MonoMod does not consider the coreified vanilla Celeste copy in the workspace, as it is named Celeste.Core.dll instead of Celeste.dll.

I cannot commit to your branch, so I have sent a patch file in #modding_dev on the Celeste Discord server.
I tested it by running MiniInstaller twice from a fresh copy of Celeste and confirmed it works.

SnipUndercover · 2026-05-29T23:40:40Z

Also this doesn't really solve the problem of Celeste.dll being missing when the installation is interrupted. We could skip deleting Celeste.dll and just have the copy from the workspace overwrite the dll?

DashingCat · 2026-06-02T22:32:36Z

From my testing, @SnipUndercover patches work on Linux as well.

SnipUndercover

Confirmed the PR works on MacOS.
LGTM.

maddie480-bot · 2026-06-24T14:45:44Z

The pull request was approved and entered the 3-day last-call window. Since no PR should be merged within 3 days of the next rolling release, the last-call window is extended further.
If no further reviews happen, it will end on Jun 28, 2026, 12:00 AM UTC, after which the pull request will be able to be merged.

maddie480-bot · 2026-06-28T00:45:49Z

…-miniinstaller" This reverts commit 384acc1, reversing changes made to 6988c0d.

…o-miniinstaller" This reverts commit 19d6ce8.

maddie480-bot added the 0: draft This PR is not ready for review yet (bot-managed) label Dec 10, 2025

DashingCat marked this pull request as ready for review December 14, 2025 18:47

maddie480-bot added 1: review needed This PR needs 2 approvals to be merged (bot-managed) and removed 0: draft This PR is not ready for review yet (bot-managed) labels Dec 14, 2025

Wartori54 requested changes Dec 16, 2025

View reviewed changes

Comment thread MiniInstaller/Program.cs Outdated

Comment thread MiniInstaller/LibAndDepHandling.cs

Comment thread MiniInstaller/Program.cs

Comment thread MiniInstaller/Program.cs Outdated

maddie480-bot added 2: changes requested This PR cannot be merged because changes were requested (bot-managed) and removed 1: review needed This PR needs 2 approvals to be merged (bot-managed) labels Dec 16, 2025

DashingCat requested a review from Wartori54 December 17, 2025 23:57

Wartori54 requested changes Dec 18, 2025

View reviewed changes

Comment thread MiniInstaller/DepCalls.cs Outdated

Comment thread MiniInstaller/DepCalls.cs Outdated

DashingCat requested a review from Wartori54 December 18, 2025 22:45

Wartori54 approved these changes Dec 22, 2025

View reviewed changes

maddie480-bot added 1: review needed This PR needs 2 approvals to be merged (bot-managed) and removed 2: changes requested This PR cannot be merged because changes were requested (bot-managed) labels Dec 22, 2025

microlith57 approved these changes Jan 3, 2026

View reviewed changes

maddie480-bot added 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) and removed 1: review needed This PR needs 2 approvals to be merged (bot-managed) labels Jan 3, 2026

SnipUndercover requested changes Jan 3, 2026

View reviewed changes

SnipUndercover self-assigned this Jan 3, 2026

maddie480-bot added 2: changes requested This PR cannot be merged because changes were requested (bot-managed) and removed 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) labels Jan 3, 2026

microlith57 added the 2: testing needed This PR needs to be tested on one or more platforms label Jan 8, 2026

maddie480-bot added the changes requested label Jan 8, 2026

maddie480 removed the changes requested label Jan 8, 2026

DashingCat added 3 commits May 29, 2026 20:43

Add workspace to MiniInstaller

faa67c6

Address comments related to MiniInstaller's workspace

1d39e0c

Use Path.PathSeparator instead of :

a0b3adb

Add missing parameter names

186809b

DashingCat force-pushed the 983-add-workspace-to-miniinstaller branch from 33be988 to 186809b Compare May 29, 2026 20:43

SnipUndercover requested changes May 29, 2026

View reviewed changes

SnipUndercover added 3 commits June 1, 2026 23:32

Fix Piton apphost being resolved as managed Celeste assembly

2c9b8d0

Move apphost bind and XML merge to workspace

482740b

Skip deleting Celeste.dll early

c59853f

Merge branch 'dev' into 983-add-workspace-to-miniinstaller

9cfaf7f

SnipUndercover approved these changes Jun 24, 2026

View reviewed changes

maddie480-bot added 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) and removed 2: changes requested This PR cannot be merged because changes were requested (bot-managed) labels Jun 24, 2026

DashingCat removed the 2: testing needed This PR needs to be tested on one or more platforms label Jun 24, 2026

maddie480-bot added 4: ready to merge This PR was approved and the last-call window is over (bot-managed) and removed 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) labels Jun 28, 2026

SnipUndercover merged commit 384acc1 into EverestAPI:dev Jun 28, 2026
3 checks passed

maddie480 added a commit that referenced this pull request Jul 25, 2026

Revert "Merge pull request #1037 from DashingCat/983-add-workspace-to…

19d6ce8

…-miniinstaller" This reverts commit 384acc1, reversing changes made to 6988c0d.

maddie480 added a commit that referenced this pull request Jul 25, 2026

Reapply "Merge pull request #1037 from DashingCat/983-add-workspace-t…

be52644

…o-miniinstaller" This reverts commit 19d6ce8.

DashingCat mentioned this pull request Aug 14, 2026

Intern BinaryPacker.Element and EntityData values, and PlaybackData animation ids. #1149

Merged

	File.Move(srcPath, dstPath, true);
	File.Move(srcPath, dstPath, overwrite: true);

	File.Copy(steamworksLibSrc, steamworksLibDst, true);
	File.Copy(steamworksLibSrc, steamworksLibDst, overwrite: true);

	Directory.Delete(Globals.PathMiniInstallerWorkspace, true);
	Directory.Delete(Globals.PathMiniInstallerWorkspace, recursive: true);

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

DashingCat commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Wartori54 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DashingCat commented Dec 17, 2025

Uh oh!

Wartori54 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

DashingCat commented Dec 18, 2025

Uh oh!

microlith57 left a comment

Choose a reason for hiding this comment

Uh oh!

microlith57 Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

microlith57 Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

microlith57 Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

maddie480-bot commented Jan 3, 2026

Uh oh!

SnipUndercover left a comment

Choose a reason for hiding this comment

Uh oh!

DashingCat commented Jan 8, 2026

Uh oh!

SnipUndercover left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SnipUndercover commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DashingCat commented Jun 2, 2026

Uh oh!

SnipUndercover left a comment

Choose a reason for hiding this comment

Uh oh!

maddie480-bot commented Jun 24, 2026

Uh oh!

maddie480-bot commented Jun 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

DashingCat commented Dec 10, 2025 •

edited

Loading

SnipUndercover left a comment •

edited

Loading

SnipUndercover commented May 29, 2026 •

edited

Loading