GH-81 Add support for #onlinePlayers with specific permissions#81
Conversation
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
multification-core/test/com/eternalcode/multification/MultificationTest.java (1)
59-69: Test implementation could be more realistic.The current test returns all players regardless of the permission parameter. Consider making the permission check more realistic or updating the comment to clarify this is intentional test behavior.
- // Simulating permission check - if (viewer.uuid.equals(ROLLCZI_UUID) || viewer.uuid.equals(LUCKI_UUID)) { + // Test implementation: return all players for any permission + if (viewer.uuid.equals(ROLLCZI_UUID) || viewer.uuid.equals(LUCKI_UUID)) {
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
multification-bukkit/src/com/eternalcode/multification/bukkit/BukkitViewerProvider.java(1 hunks)multification-core/src/com/eternalcode/multification/notice/NoticeBroadcast.java(1 hunks)multification-core/src/com/eternalcode/multification/notice/NoticeBroadcastImpl.java(1 hunks)multification-core/src/com/eternalcode/multification/viewer/ViewerProvider.java(1 hunks)multification-core/test/com/eternalcode/multification/MultificationTest.java(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build (17)
🔇 Additional comments (3)
multification-core/src/com/eternalcode/multification/viewer/ViewerProvider.java (1)
14-14: Interface addition looks good.The new method signature follows the existing pattern and provides a clean way to filter online players by permission.
multification-core/src/com/eternalcode/multification/notice/NoticeBroadcast.java (1)
36-37: Interface addition is consistent.The method follows the existing builder pattern with proper annotations.
multification-bukkit/src/com/eternalcode/multification/bukkit/BukkitViewerProvider.java (1)
27-36: Permission filtering implementation looks correct.The method properly filters online players by checking the permission and returns an unmodifiable collection, which is good practice.
…ticeBroadcastImpl.java Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
vLuckyyy
changed the title
2 participants
No description provided.