{{ message }}
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes redundant if (storage) guards in loadServicePreferences() when clearing invalid/oversized stored preferences, relying on the existing early-return when localStorage is unavailable.
Changes:
- Removed unnecessary
if (storage)checks before callingstorage.removeItem('servicePreferences')in two cleanup paths. - Kept existing error handling via
try/catcharoundremoveItemcalls.
Comment on lines
1486
to
1490
There was a problem hiding this comment.
Project convention requires updating the root CHANGELOG.md whenever the codebase is modified; please add an entry describing this service-preferences cleanup (see .github/copilot-instructions.md:48-53).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix this, remove the redundant
if (storage)guards in the two inner cleanup blocks and callstorage.removeItem('servicePreferences')directly.This preserves functionality because execution can only reach those blocks after the earlier
if (!storage) return null;guard.Where to change:
config/var/www/admin/control-panel/external-services/external-services.jsloadServicePreferences()around lines 1488–1511.Suggested fixes powered by Copilot Autofix. Review carefully before merging.