{{ message }}
Repository navigation
Add a new blockBreakEffect method and deprecate World#playEffect - #2110
Open
Owen1212055 wants to merge 4 commits into
Open
Owen1212055 wants to merge 4 commits into
Owen1212055 wants to merge 4 commits into
Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please give feedback on the deprecation of
World#playEffectand the oldWorld#queueBlockBreakEffectmethod.I was also split between making a separate method for the block break effect or making some kind of generic
playEffect(Vector3 pos, int effect, T data)method that would do a bunch of instanceof checks to correctly adapt the data.If a generic play effect method is preferred rather than a specific playBreakBlockEffect method, let me know!