Create 5ch.xml#19126
Conversation
There was a problem hiding this comment.
Please do not use wildcard targets if possible.
There was a problem hiding this comment.
Is this better?
<target host="\w+.5ch.net" />
5ch (formerly 2ch) is the largest forum in Japan. 5ch has fewer servers. But it's fluid rather than fixed.
The former 2ch (not 5ch) has grown to over 100 subdomains: sample
There was a problem hiding this comment.
The host attribute is not a regex, so this won't work. If it's actually impossible to list all subdomains, a wildcard is acceptable.
There was a problem hiding this comment.
I think a wildcard is good.
Perhaps they are worried about connection errors with HTTPS. But, SSL has been used since the previous 2ch (current 5ch). The web operator is SSL-enabled, can also connect to both via HTTP. It won't cause any problems.
On the other hand, the official smartphone loading program (Ajax, still output HTTP) has been stalled in development. Programmers are not active. And external third party web tools also.
cschanaj
left a comment
cschanaj
left a comment
There was a problem hiding this comment.
Thank you for your PR. Travis did not pass because you missed some trailing slashes for the test URLs. You may apply the suggestions to fix this. Besides, would you please use tabs for indentations as suggested by our contributing guide ?
maboroshin
left a comment
maboroshin
left a comment
There was a problem hiding this comment.
@cschanaji Thanks for the assist.
Seems like a good change. Now we just have to wait for the merge?
Co-authored-by: Chan Chak Shing <cschanaj@users.noreply.github.com>
Co-authored-by: Chan Chak Shing <cschanaj@users.noreply.github.com>
Co-authored-by: Chan Chak Shing <cschanaj@users.noreply.github.com>
Co-authored-by: Chan Chak Shing <cschanaj@users.noreply.github.com>
Co-authored-by: Chan Chak Shing <cschanaj@users.noreply.github.com>
4 participants
List related ruleset
Currently
2ch.netis being redirected to5ch.net.P.S. ( September 8, 2020)
Checked on September 8, 2020 at here