{{ message }}
Various v2 theme cleanup and adjust#485
Merged
Merged
Conversation
Owner
Author
|
@coderabbitai review |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@owlplug-client/src/main/resources/fxml/HomeView.fxml`:
- Line 186: The unresolved tile’s alert icon is missing the warning styling and
fixed size that the old asset provided. Update the FontIcon in HomeView.fxml so
it still reads as a danger/alert indicator and matches the neighboring stat icon
sizing, using the existing icon element and its style/size properties rather
than leaving it unstyled.
In `@owlplug-client/src/main/resources/owlplug.css`:
- Line 51: There is an unnecessary blank line before the `-owlplug-color-text`
declaration in the stylesheet block; move `-owlplug-color-text` up to sit
directly with the surrounding custom properties in `owlplug.css` so the block
matches the expected declaration order and passes Stylelint.
- Around line 373-377: Keep the .pane-card surface styling intact in owlplug.css
for now, because multiple views still rely on it. Restore or preserve the
background and radius styling in the .pane-card rule used by
PluginInfoView.fxml, ProjectInfoView.fxml, ComponentInfoView.fxml,
PackageInfoView.fxml, WelcomeView.fxml, SymlinkInfoView.fxml, and
DirectoryInfoView.fxml, and only remove these styles after all of those
consumers have been migrated.
In `@owlplug-theme/src/main/scss/owlplug-dark.scss`:
- Around line 65-75: The danger palette needs to keep the foreground swatch
readable on the dark theme canvas, since $danger-4 currently feeds $danger-fg
and is too low-contrast for text/icons. Update the danger scale in
owlplug-dark.scss by making $danger-4 lighter, or adjust the $danger-fg
assignment to use a lighter danger stop while keeping the rest of the palette
intact. Use the $danger-4 and $danger-fg symbols to locate and change the
mapping consistently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 1f3f1954-63b0-4a68-a6af-9a1ffe8088fe
⛔ Files ignored due to path filters (5)
owlplug-client/src/main/resources/icons/check-green-16.pngis excluded by!**/*.png,!**/*.pngowlplug-client/src/main/resources/icons/cross-red-16.pngis excluded by!**/*.png,!**/*.pngowlplug-client/src/main/resources/icons/loading-grey-16.pngis excluded by!**/*.png,!**/*.pngowlplug-client/src/main/resources/icons/pen-grey-16.pngis excluded by!**/*.png,!**/*.pngowlplug-client/src/main/resources/icons/play-green-16.pngis excluded by!**/*.png,!**/*.png
📒 Files selected for processing (6)
owlplug-client/src/main/java/com/owlplug/core/components/ApplicationDefaults.javaowlplug-client/src/main/java/com/owlplug/core/controllers/fragments/PluginPathFragmentController.javaowlplug-client/src/main/resources/fxml/HomeView.fxmlowlplug-client/src/main/resources/fxml/projects/ProjectsView.fxmlowlplug-client/src/main/resources/owlplug.cssowlplug-theme/src/main/scss/owlplug-dark.scss
💤 Files with no reviewable changes (2)
- owlplug-client/src/main/resources/fxml/projects/ProjectsView.fxml
- owlplug-client/src/main/java/com/owlplug/core/components/ApplicationDefaults.java
7adab4b to
1c80a0c
Compare
1c80a0c to
70f72ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.