Various v2 theme cleanup and adjust by DropSnorz · Pull Request #485 · DropSnorz/OwlPlug · GitHub
Skip to content

Various v2 theme cleanup and adjust#485

Merged
DropSnorz merged 2 commits into
v2from
fix/theme-adjust
Jun 27, 2026
Merged

Various v2 theme cleanup and adjust#485
DropSnorz merged 2 commits into
v2from
fix/theme-adjust

Conversation

@DropSnorz

Copy link
Copy Markdown
Owner

No description provided.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

@DropSnorz DropSnorz changed the base branch from master to v2 June 24, 2026 17:37
@DropSnorz DropSnorz marked this pull request as ready for review June 27, 2026 18:18
@DropSnorz

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@owlplug-client/src/main/resources/fxml/HomeView.fxml`:
- Line 186: The unresolved tile’s alert icon is missing the warning styling and
fixed size that the old asset provided. Update the FontIcon in HomeView.fxml so
it still reads as a danger/alert indicator and matches the neighboring stat icon
sizing, using the existing icon element and its style/size properties rather
than leaving it unstyled.

In `@owlplug-client/src/main/resources/owlplug.css`:
- Line 51: There is an unnecessary blank line before the `-owlplug-color-text`
declaration in the stylesheet block; move `-owlplug-color-text` up to sit
directly with the surrounding custom properties in `owlplug.css` so the block
matches the expected declaration order and passes Stylelint.
- Around line 373-377: Keep the .pane-card surface styling intact in owlplug.css
for now, because multiple views still rely on it. Restore or preserve the
background and radius styling in the .pane-card rule used by
PluginInfoView.fxml, ProjectInfoView.fxml, ComponentInfoView.fxml,
PackageInfoView.fxml, WelcomeView.fxml, SymlinkInfoView.fxml, and
DirectoryInfoView.fxml, and only remove these styles after all of those
consumers have been migrated.

In `@owlplug-theme/src/main/scss/owlplug-dark.scss`:
- Around line 65-75: The danger palette needs to keep the foreground swatch
readable on the dark theme canvas, since $danger-4 currently feeds $danger-fg
and is too low-contrast for text/icons. Update the danger scale in
owlplug-dark.scss by making $danger-4 lighter, or adjust the $danger-fg
assignment to use a lighter danger stop while keeping the rest of the palette
intact. Use the $danger-4 and $danger-fg symbols to locate and change the
mapping consistently.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 1f3f1954-63b0-4a68-a6af-9a1ffe8088fe

📥 Commits

Reviewing files that changed from the base of the PR and between 63c0921 and 7adab4b.

⛔ Files ignored due to path filters (5)
  • owlplug-client/src/main/resources/icons/check-green-16.png is excluded by !**/*.png, !**/*.png
  • owlplug-client/src/main/resources/icons/cross-red-16.png is excluded by !**/*.png, !**/*.png
  • owlplug-client/src/main/resources/icons/loading-grey-16.png is excluded by !**/*.png, !**/*.png
  • owlplug-client/src/main/resources/icons/pen-grey-16.png is excluded by !**/*.png, !**/*.png
  • owlplug-client/src/main/resources/icons/play-green-16.png is excluded by !**/*.png, !**/*.png
📒 Files selected for processing (6)
  • owlplug-client/src/main/java/com/owlplug/core/components/ApplicationDefaults.java
  • owlplug-client/src/main/java/com/owlplug/core/controllers/fragments/PluginPathFragmentController.java
  • owlplug-client/src/main/resources/fxml/HomeView.fxml
  • owlplug-client/src/main/resources/fxml/projects/ProjectsView.fxml
  • owlplug-client/src/main/resources/owlplug.css
  • owlplug-theme/src/main/scss/owlplug-dark.scss
💤 Files with no reviewable changes (2)
  • owlplug-client/src/main/resources/fxml/projects/ProjectsView.fxml
  • owlplug-client/src/main/java/com/owlplug/core/components/ApplicationDefaults.java

Comment thread owlplug-client/src/main/resources/fxml/HomeView.fxml
Comment thread owlplug-client/src/main/resources/owlplug.css
Comment thread owlplug-client/src/main/resources/owlplug.css
Comment thread owlplug-theme/src/main/scss/owlplug-dark.scss
@DropSnorz DropSnorz merged commit 84a0217 into v2 Jun 27, 2026
2 of 4 checks passed
@DropSnorz DropSnorz added this to the 2.0.0 milestone Jun 27, 2026
@DropSnorz DropSnorz self-assigned this Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant