Ensure file is relative to GITHUB_WORKSPACE.#4
Conversation
StefSchenkelaars
left a comment
StefSchenkelaars
left a comment
There was a problem hiding this comment.
@reitermarkus Thanks for the mention, I indeed missed them. And thanks for the PR.
The main thing here are tests. Could you add some test cases validating that this works.
|
Simplified the implementation and added some tests. |
reitermarkus
force-pushed
the
github-workspace
branch
from
8173ca3 to
2e0316e
Compare
StefSchenkelaars
left a comment
StefSchenkelaars
left a comment
There was a problem hiding this comment.
Hi @reitermarkus, thanks for the update, looks good!
So I was thinking on how to validate that this actually works. I've now added an e2e GitHub action to the ci workflow. It basically runs the bundle exec rspec spec/integration command. So if you now look in the files changed of this PR, you can see that it works for the case without these relative paths. (note that I merged master into your branch).
So if you feel like it, you can add an end 2 end test with a relative path to really ensure that it works but if not, you can merge it (it's approved).
I actually can't because I don't have rights on this repo. |
2 participants
When running
rspecin a subdirectory, no annotations are shown currently, sincefilehas to be relative to theGITHUB_WORKSPACE.