Add `ScanForTypesAttribute` as dedicated attribute for custom type handling by Copilot · Pull Request #53 · Dreamescaper/ServiceScan.SourceGenerator · GitHub
Skip to content

Add ScanForTypesAttribute as dedicated attribute for custom type handling#53

Merged
Dreamescaper merged 6 commits into
mainfrom
copilot/add-custom-handler-attribute
Mar 20, 2026
Merged

Add ScanForTypesAttribute as dedicated attribute for custom type handling#53
Dreamescaper merged 6 commits into
mainfrom
copilot/add-custom-handler-attribute

Conversation

Copilot AI commented Mar 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GenerateServiceRegistrationsAttribute with CustomHandler set was awkward — registration-specific properties (Lifetime, AsSelf, AsImplementedInterfaces, KeySelector) are meaningless in that context, and the attribute name itself is misleading since the handler may not register anything.

Changes

  • New ScanForTypesAttribute — contains all filtering properties (AssignableTo, TypeNameFilter, AttributeFilter, etc.) and Handler, but none of the registration-specific ones
  • CustomHandler on GenerateServiceRegistrationsAttribute marked [Obsolete("Use ScanForTypesAttribute instead.", error: false)] — still functional
  • New diagnostics:
    • DI0013 — ScanForTypesAttribute used without Handler set
    • DI0014 — ScanForTypesAttribute and GenerateServiceRegistrationsAttribute used on the same method
  • Second incremental generator provider wired up for the new attribute, sharing the existing FindServicesToRegister / source generation pipeline
  • Version bumped to 3.0

Migration

// Before (deprecated)
[GenerateServiceRegistrations(AssignableTo = typeof(IEndpoint), CustomHandler = nameof(IEndpoint.MapEndpoint))]
public static partial IEndpointRouteBuilder MapEndpoints(this IEndpointRouteBuilder endpoints);

// After
[ScanForTypes(AssignableTo = typeof(IEndpoint), Handler = nameof(IEndpoint.MapEndpoint))]
public static partial IEndpointRouteBuilder MapEndpoints(this IEndpointRouteBuilder endpoints);
Original prompt

This section details on the original issue you should resolve

<issue_title>Create separate attribute for custom handling</issue_title>
<issue_description>Existing GenerateServiceRegistrations attribute becomes a bit messy. When CustomHandler is specified, properties like AsSelf, Lifetime, etc become incompatible.
Also, naming GenerateServiceRegistrations becomes incorrect, as CustomHandler does not nessesary does anything regarding registrations.

We should add a separate attribute, which only applies to CustomHandler. It should contain all filtering properties, but nothing related to service registration.
Existing CustomHandler on GenerateServiceRegistrations attribute should be marked as Obsolete (but functional for now).</issue_description>

Comments on the Issue (you are @copilot in this section)

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

@Dreamescaper
Add GenerateServiceHandlerAttribute and mark CustomHandler as Obsolet…
1b28b93 
…e on GenerateServiceRegistrationsAttribute

Co-authored-by: Dreamescaper <17177729+Dreamescaper@users.noreply.github.com>
Copilot AI changed the title [WIP] Add separate attribute for custom handling Add GenerateServiceHandlerAttribute as dedicated attribute for custom type handling Mar 20, 2026
Copilot AI requested a review from Dreamescaper March 20, 2026 12:44
@Dreamescaper

Dreamescaper commented Mar 20, 2026

Copy link
Copy Markdown
Owner

@Dreamescaper
Bump major version to 3.0
f138be0 
Co-authored-by: Dreamescaper <17177729+Dreamescaper@users.noreply.github.com>

Copilot AI commented Mar 20, 2026

Copy link
Copy Markdown
Contributor Author

@copilot
Bump major version in version.json

Done in f138be0 — bumped version from 2.4 to 3.0.

@Dreamescaper Dreamescaper marked this pull request as ready for review March 20, 2026 12:55
@Dreamescaper

Dreamescaper commented Mar 20, 2026

Copy link
Copy Markdown
Owner

@copilot
I suggest to rename GenerateServiceHandler to ScanForTypes (we'll add other functionality later, like returning found types as a collection).
Also, CustomHandler -> Handler (no point specifying that it is custom now when it is separate from registration attribute).

Let me know if you have other naming suggestions.

@Dreamescaper
Rename GenerateServiceHandlerAttribute to ScanForTypesAttribute, Cust…
dfd4989 
…omHandler to Handler

Co-authored-by: Dreamescaper <17177729+Dreamescaper@users.noreply.github.com>

Copilot AI commented Mar 20, 2026

Copy link
Copy Markdown
Contributor Author

@copilot
I suggest to rename GenerateServiceHandler to ScanForTypes (we'll add other functionality later, like returning found types as a collection).
Also, CustomHandler -> Handl...

Done in dfd4989:

  • GenerateServiceHandlerAttribute → ScanForTypesAttribute
  • CustomHandler property on the new attribute → Handler

The [Obsolete] on GenerateServiceRegistrationsAttribute.CustomHandler now points to ScanForTypesAttribute. The AttributeModel reads "Handler" first, then falls back to "CustomHandler" so both the new and legacy attributes work correctly.

Copilot AI changed the title Add GenerateServiceHandlerAttribute as dedicated attribute for custom type handling Add ScanForTypesAttribute as dedicated attribute for custom type handling Mar 20, 2026
@Dreamescaper

Dreamescaper commented Mar 20, 2026

Copy link
Copy Markdown
Owner

@copilot
Merge lastest main and fix the build.

Copilot AI and others added 2 commits March 20, 2026 13:19
Merge remote-tracking branch 'origin/main' into copilot/add-custom-ha…
0ee5cad 
…ndler-attribute
@Dreamescaper
Merge main and fix ScanForTypesAttribute to use [Embedded] instead of…
2291b64 
… [Conditional]

Co-authored-by: Dreamescaper <17177729+Dreamescaper@users.noreply.github.com>

Copilot AI commented Mar 20, 2026

Copy link
Copy Markdown
Contributor Author

Copilot AI requested a review from Dreamescaper March 20, 2026 13:21
@Dreamescaper Dreamescaper merged commit d14cace into main Mar 20, 2026
1 check passed
@Dreamescaper Dreamescaper deleted the copilot/add-custom-handler-attribute branch March 20, 2026 13:27
This was referenced Mar 26, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dreamescaper Dreamescaper Awaiting requested review from Dreamescaper

Assignees

@Dreamescaper Dreamescaper

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create separate attribute for custom handling

2 participants

@Dreamescaper