{{ message }}
🧹 [code health] Remove legacy fallback logic from Applications extension#4
Open
Dor-bl wants to merge 10 commits into
Open
🧹 [code health] Remove legacy fallback logic from Applications extension#4Dor-bl wants to merge 10 commits into
Dor-bl wants to merge 10 commits into
Conversation
Owner
Author
|
@copilot resolve the merge conflicts in this pull request |
I have successfully updated the branch and resolved the conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What: Removed the deprecated
try/exceptfallback logic in all app management methods (activate_app,background_app,is_app_installed,install_app,remove_app,terminate_app,query_app_state,app_strings) withinappium/webdriver/extensions/applications.py. The class now relies exclusively onmobile:scripts.💡 Why: This improves maintainability by removing legacy endpoints (e.g.
Command.ACTIVATE_APP,Command.BACKGROUND), simplifying the control flow, and eliminating the need forCanRememberExtensionPresencechecking logic, aligning the codebase with standard Appium 2 behavior.✅ Verification: Verified by compiling the file, running
rufffor linting, and executing theapp_test.pyunit tests withpytest, which all passed successfully.✨ Result: A cleaner, simpler
Applicationsextension class with legacy cruft removed and no impact to intended public API usage.PR created automatically by Jules for task 9502228454495900322 started by @Dor-bl