fix: allow Integration classes in disabled_integrations typing by Dmao233 · Pull Request #1 · Dmao233/sentry-python · GitHub
Skip to content

fix: allow Integration classes in disabled_integrations typing - #1

Draft
Dmao233 wants to merge 1 commit into
masterfrom
cursor/fix-7460-disabled-integrations-typing-a366
Draft

Dmao233 wants to merge 1 commit into
masterfrom
cursor/fix-7460-disabled-integrations-typing-a366

Conversation

@Dmao233

@Dmao233 Dmao233 commented Sep 14, 2026

Copy link
Copy Markdown
Owner

Description

Allow disabled_integrations to accept integration classes (type[Integration]), matching runtime usage and the annotation in integrations/init.py. Fixes mypy errors when passing e.g. FalconIntegration.

Issues

Reminders

  • Please add tests to validate your changes, and lint your code using uv run ruff.
  • Add GH Issue ID & Linear ID (if applicable)
  • PR title should use conventional commit style
Open in Web Open in Cursor 

Co-authored-by: CenFangyu <Dmao233@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sentry_sdk.init(disable_integration=...) annotation incorrect

1 participant