Repository navigation
Fixes #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fixes #581
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,15 +55,15 @@ static int evdi_platform_drv_usb(__always_unused struct notifier_block *nb, | |
|
|
||
| if (!usb_dev) | ||
| return 0; | ||
| if (action != BUS_NOTIFY_DEL_DEVICE) | ||
| if (action != USB_DEVICE_REMOVE) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. LGTM. |
||
| return 0; | ||
|
|
||
| for (i = 0; i < EVDI_DEVICE_COUNT_MAX; ++i) { | ||
| pdev = g_ctx.devices[i]; | ||
| if (!pdev) | ||
| continue; | ||
| evdi_platform_device_unlink_if_linked_with(pdev, &usb_dev->dev); | ||
| if (pdev->dev.parent == &usb_dev->dev) { | ||
| if (evdi_platform_device_unlink_if_linked_with(pdev, &usb_dev->dev) && | ||
| i >= evdi_initial_device_count) { | ||
|
Comment on lines
+65
to
+66
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. LGTM. |
||
| EVDI_INFO("Parent USB removed. Removing evdi.%d\n", i); | ||
| evdi_platform_dev_destroy(pdev); | ||
| evdi_platform_drv_context_lock((&g_ctx)); | ||
|
|
||

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this comment.
The commit description is sufficient in this case.
Please rename the commit to 'Add drm_atomic_commit compatibility aliases for Linux 7.1+' or something similar to this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FireBurn I've noticed that this is already handled in the compatibility work from #572, which addresses the drm_atomic_state -> drm_atomic_commit rename without the version-specific alias. I think we should stick with the existing approach. Please drop this commit.