{{ message }}
fix: per-process PONYTAIL_DEFAULT_MODE=off no longer clears shared flag - #813
Open
tanish19078 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #809 (partial: the env-override blast radius; full session-scoping of /ponytail-review is a bigger redesign, deliberately out of scope).
Starting one session with
PONYTAIL_DEFAULT_MODE=offranclearMode()inponytail-activate.js, deleting the shared flag and silently turning ponytail off for every other session's subagents. Reproduced per the issue: flagfull-> env-off activate -> flag gone.isPerProcessOff()inhooks/ponytail-config.js: true only when the env override says off while the configured default is something else (a config-file off still means off everywhere).ponytail-activate.jsskipsclearMode()in that case;ponytail-subagent.jsexits silently so the exempt session injects nothing.Verification: issue repro now leaves flag
full(hook prints OK, exit 0); config-file off still clears stale flags;node --test tests/*.test.js84/84 +pi-extension23/23 pass