{{ message }}
fix: keep hook stdin-fallback timer ref'd so it fires on Windows - #812
Open
tanish19078 wants to merge 1 commit into
Open
fix: keep hook stdin-fallback timer ref'd so it fires on Windows#812tanish19078 wants to merge 1 commit into
tanish19078 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #790 (follow-up to #443; related open PR #806).
The 1s stdin-fallback timer in
hooks/ponytail-mode-tracker.jswas.unref()'d, so in exactly the stdin-swallow scenario it guards, the fallback cannot fire and the hook falls through to Claude Code's 5s hook watchdog instead of the intended ~1s worst case..unref()on the fallback timer inponytail-mode-tracker.js(and updated the stale comment claiming unref avoids latency).hooks/ponytail-subagent.js, which shares the identical fallback pattern.Verification:
node --test tests/*.test.js— 84/84 pass, includingponytail-mode-tracker self-exits when stdin never closes